Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix v issue #7

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

francostellari
Copy link
Contributor

Summary

I just tested the new chart... the new command for KS would be:

helm install ocm-transport-plugin oci://ghcr.io/kubestellar/ocm-transport-plugin/chart/ocm-transport-plugin --version 0.1.0 --set transport_cp_name=imbs1 --set wds_cp_name=wds1

However, there is an issue, the chart is referencing the controlelr image with a v:

 Warning  Failed     19s (x3 over 56s)  kubelet            Failed to pull image "ghcr.io/kubestellar/ocm-transport-plugin/transport-controller:v0.1.0": rpc error: code = NotFound desc = failed to pull and unpack image "ghcr.io/kubestellar/ocm-transport-plugin/transport-controller:v0.1.0": failed to resolve reference "ghcr.io/kubestellar/ocm-transport-plugin/transport-controller:v0.1.0": ghcr.io/kubestellar/ocm-transport-plugin/transport-controller:v0.1.0: not found

I think we need to change the sed command in https://github.com/kubestellar/ocm-transport-plugin/blob/main/.github/workflows/goreleaser.yml from:

sed -i 's@OTP_IMAGE_PLACEHOLDER@${{ env.REGISTRY }}/${{ env.CONTROLLER_IMAGE }}:${{ github.ref_name }}@g' ${{ env.CHART_PATH }}/templates/controller.yaml

to:

sed -i 's@OTP_IMAGE_PLACEHOLDER@${{ env.REGISTRY }}/${{ env.CONTROLLER_IMAGE }}:${chartVersion}@g' ${{ env.CHART_PATH }}/templates/controller.yaml

Related issue(s)

Fixes #

Signed-off-by: francostellari <[email protected]>
Copy link
Collaborator

@nirrozenbaum nirrozenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks!

@nirrozenbaum nirrozenbaum merged commit d01db69 into kubestellar:main Mar 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants