MTV-1726: Edit VMs list in migration plan #1414

jschuler · 2024-12-16T15:32:12Z

https://issues.redhat.com/browse/MTV-1726

Design story:
https://issues.redhat.com/browse/HPUX-166

Provide users the possibility to add more VMs (not just delete) to an existing plan.

For the mappings section, I reused the plan details mappings tab section, since it can patch existing mappings

The user can only edit the VMs in an existing plan when the plan is in Ready state (so not running/failed/error etc.)

See video of before (green border)/after:

Screen.Recording.2024-12-13.at.12.04.40.PM.mov

jschuler · 2024-12-16T15:56:40Z

packages/forklift-console-plugin/src/components/page/StandardPageWithExpansion.tsx

@@ -0,0 +1,149 @@
+import React, { useState } from 'react';


this is basically a copy of packages/forklift-console-plugin/src/components/page/StandardPageWithSelection.tsx but without selection, only expansion

This variation is needed for Edit VMs case since there should be no checkboxes, just expandable rows.

jschuler · 2024-12-16T15:58:01Z

packages/forklift-console-plugin/src/modules/Plans/utils/types/PlanEditAction.ts

@@ -0,0 +1 @@
+export type PlanEditAction = 'PLAN' | 'VMS';


it will allow us next (with small changes like this) to edit plans too

jschuler · 2024-12-16T15:59:02Z

packages/forklift-console-plugin/src/modules/Plans/views/details/tabs/Mappings/PlanMappings.tsx

-  loadError: unknown;
+  loaded?: boolean;
+  loadError?: unknown;
+  planMappingsState: PlanMappingsSectionState;


I lifted the state up so that we can reuse planmappings from Edit VMs case

jschuler · 2024-12-16T16:02:45Z

packages/forklift-console-plugin/src/modules/Plans/views/edit/PlanEditPage.tsx

+
+import '../create/PlanCreatePage.style.css';
+
+export const PlanEditPage: React.FC<{


initially copied from PlanCreatePage, but there were enough changes to make it its own component

codecov-commenter · 2024-12-16T19:39:39Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 36.36%. Comparing base (13484d0) to head (6b527bf).
Report is 212 commits behind head on main.

Files with missing lines	Patch %	Lines
...ackages/forklift-console-plugin/src/utils/fetch.ts	44.44%	5 Missing ⚠️
...kages/forklift-console-plugin/src/utils/isEmpty.ts	50.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1414      +/-   ##
==========================================
- Coverage   36.81%   36.36%   -0.46%     
==========================================
  Files         158      157       -1     
  Lines        2548     2533      -15     
  Branches      599      597       -2     
==========================================
- Hits          938      921      -17     
- Misses       1428     1430       +2     
  Partials      182      182

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MTV-1686] Simplify/update migration plan status cell Signed-off-by: Joachim Schuler <[email protected]>

Signed-off-by: Joachim Schuler <[email protected]>

yaacov · 2024-12-29T06:09:08Z

@sgratch please review

@jschuler happy holidays, @sgratch the maintainer, asked to review big PRs so we will wait for her review.

Signed-off-by: Joachim Schuler <[email protected]>

metalice

Hey @jschuler

I went over the PR, following our best practices, and I didn't comment on everything as I trust that you will understand from the comments that I did add and adjust in all the places that it fit. If something isn't clear, just let me know over Slack

packages/forklift-console-plugin/src/modules/Providers/views/migrate/useUpdateEffect.ts

...es/forklift-console-plugin/src/modules/Providers/views/migrate/reducer/createInitialState.ts

packages/forklift-console-plugin/src/modules/Plans/views/details/tabs/Mappings/PlanMappings.tsx

metalice · 2025-01-16T15:52:51Z

packages/forklift-console-plugin/src/modules/Plans/views/details/components/MappingListItem.tsx

+            ) : (
+              <Button
+                onClick={onClick}
+                variant="plain"


u can use ButtonVariant from PF

This is pre-existing code? I would say these kinds of changes are generally out-of-scope

You are right, but its a process of bringing this project to a better level

on second thought, is it necessary? we have typescript types

packages/forklift-console-plugin/src/components/page/StandardPageWithExpansion.tsx

Signed-off-by: Joachim Schuler <[email protected]>

sonarqubecloud · 2025-01-30T21:55:03Z

Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jschuler · 2025-02-03T14:57:16Z

...plugin/src/modules/Plans/views/details/components/UpdateMappings/PlanMappingsInitSection.tsx

@@ -0,0 +1,117 @@
+import React from 'react';


Originally from here

Lifted up since it's used in multiple locations now

jschuler mentioned this pull request Dec 16, 2024

MTV-1726: Add vms to existing plans #1406

Closed

jschuler requested a review from yaacov December 16, 2024 15:33

jschuler commented Dec 16, 2024

View reviewed changes

Merge pull request kubev2v#1411 from jpuzz0/MTV-1686-status-updates

003bc27

[MTV-1686] Simplify/update migration plan status cell Signed-off-by: Joachim Schuler <[email protected]>

jschuler force-pushed the mtv-1726_add-vms branch from 999f277 to 003bc27 Compare December 18, 2024 16:35

merge

86620ef

Signed-off-by: Joachim Schuler <[email protected]>

rebase | use k8spatch

90cb409

Signed-off-by: Joachim Schuler <[email protected]>

jschuler requested a review from sgratch January 10, 2025 20:08

jschuler added 2 commits January 10, 2025 16:18

simplify

4cf4327

Signed-off-by: Joachim Schuler <[email protected]>

Allow plan mappings to be modified even if a VM has migrated

0eafaf8

Signed-off-by: Joachim Schuler <[email protected]>

metalice reviewed Jan 16, 2025

View reviewed changes

sgratch added the enhancement Categorizes issue or PR as related to a new feature. label Jan 17, 2025

jschuler added 10 commits January 17, 2025 06:21

handle edge case of VM not found

a95afef

Signed-off-by: Joachim Schuler <[email protected]>

plans actions dropdown

9a9e9c6

merge

55d9da3

PR comments

9298a8b

refactor

f453a47

k8s fetch

4adb0f9

review comments

2926c19

merge

5b59a75

pull back edit to ready plan state only

c1d9559

more

6b527bf

jschuler commented Feb 3, 2025

View reviewed changes

sgratch added this to the next milestone Feb 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MTV-1726: Edit VMs list in migration plan #1414

MTV-1726: Edit VMs list in migration plan #1414

jschuler commented Dec 16, 2024 •

edited

Loading

jschuler Dec 16, 2024 •

edited

Loading

jschuler Dec 16, 2024

jschuler Dec 16, 2024

jschuler Dec 16, 2024

codecov-commenter commented Dec 16, 2024 •

edited

Loading

yaacov commented Dec 29, 2024

metalice left a comment

metalice Jan 16, 2025

jschuler Jan 27, 2025

metalice Jan 28, 2025

jschuler Jan 29, 2025

sonarqubecloud bot commented Jan 30, 2025

jschuler Feb 3, 2025

jschuler Feb 3, 2025


		import '../create/PlanCreatePage.style.css';

		export const PlanEditPage: React.FC<{

MTV-1726: Edit VMs list in migration plan #1414

Are you sure you want to change the base?

MTV-1726: Edit VMs list in migration plan #1414

Conversation

jschuler commented Dec 16, 2024 • edited Loading

jschuler Dec 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Dec 16, 2024 • edited Loading

Codecov Report

yaacov commented Dec 29, 2024

metalice left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 30, 2025

Quality Gate passed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jschuler commented Dec 16, 2024 •

edited

Loading

jschuler Dec 16, 2024 •

edited

Loading

codecov-commenter commented Dec 16, 2024 •

edited

Loading