Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MTV-2003] Secret is loading message is wrong #1457

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Feb 5, 2025

📝 Links

https://issues.redhat.com/browse/MTV-2003

📝 Description

Don't show loading message when a secret load error exists

🎥 Demo

Before:
image

After:
image

Copy link

sonarqubecloud bot commented Feb 5, 2025

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.32%. Comparing base (13484d0) to head (daf8e79).
Report is 218 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1457      +/-   ##
==========================================
- Coverage   36.81%   36.32%   -0.50%     
==========================================
  Files         158      156       -2     
  Lines        2548     2522      -26     
  Branches      599      588      -11     
==========================================
- Hits          938      916      -22     
- Misses       1428     1601     +173     
+ Partials      182        5     -177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sgratch sgratch added the bug Categorizes issue or PR as related to a bug. label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants