Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.95] git actions: Update IPAM lane to run branch #1866

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Aug 15, 2024

What this PR does / why we need it:

Special notes for your reviewer:

Release note:


@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 15, 2024
@oshoval oshoval changed the base branch from main to release-0.95 August 15, 2024 13:32
@oshoval oshoval closed this Aug 15, 2024
@oshoval oshoval reopened this Aug 15, 2024
@oshoval
Copy link
Collaborator Author

oshoval commented Aug 15, 2024

/retest

@oshoval
Copy link
Collaborator Author

oshoval commented Aug 15, 2024

/test all

Copy link

@RamLavi
Copy link
Collaborator

RamLavi commented Aug 15, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2024
@oshoval
Copy link
Collaborator Author

oshoval commented Aug 15, 2024

/release-note-none

/approve

(lets see it pass)
thanks

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 15, 2024
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2024
@oshoval
Copy link
Collaborator Author

oshoval commented Aug 15, 2024

ah
we can just change main to be
on: [push, pull_request]
and then it will run always
will open a follow-up later because this one is branched already
#1867

@oshoval
Copy link
Collaborator Author

oshoval commented Aug 15, 2024

@brianmcarey
Hi, if you want, we can talk offline please once there is time, and try to find a solution for this
(since it hit not once)
Error response from daemon: cannot listen on the TCP port: listen tcp4 :35991: bind: address already in use
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1866/pull-e2e-cnao-lifecycle-k8s-release-0.95/1824077178757713920
(i guess just a level of port retry, or protected pre allocation, unless it is something deeper)

/retest

@oshoval
Copy link
Collaborator Author

oshoval commented Aug 15, 2024

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1866/pull-e2e-cnao-workflow-k8s-release-0.95/1824077179131006976

fails here, but not relevant to this PR, we need to tackle it later

/override pull-e2e-cnao-workflow-k8s-release-0.95

@kubevirt-bot
Copy link
Collaborator

@oshoval: Overrode contexts on behalf of oshoval: pull-e2e-cnao-workflow-k8s-release-0.95

In response to this:

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1866/pull-e2e-cnao-workflow-k8s-release-0.95/1824077179131006976

fails here, but not relevant to this PR, we need to tackle it later

/override pull-e2e-cnao-workflow-k8s-release-0.95

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@oshoval
Copy link
Collaborator Author

oshoval commented Aug 16, 2024

/retest

@kubevirt-bot kubevirt-bot merged commit 89f4b1b into kubevirt:release-0.95 Aug 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants