Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s provider to 1.30 #1908

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

RamLavi
Copy link
Collaborator

@RamLavi RamLavi commented Sep 26, 2024

What this PR does / why we need it:
This PR bumps KUBEVIRT_PROVIDER and KUBEVIRTCI_TAG to more updated values.

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 26, 2024
@RamLavi RamLavi removed the request for review from oshoval September 26, 2024 07:29
@qinqon
Copy link
Collaborator

qinqon commented Sep 26, 2024

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2024
README.md Outdated
@@ -356,7 +356,7 @@ make docker-build-registry
make cluster-up

# bridge up a local cluster with kubernetes 1.25
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change this comment / either to 1.30 or just making it generic

Copy link
Collaborator Author

@RamLavi RamLavi Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
Copy link

@oshoval
Copy link
Collaborator

oshoval commented Sep 26, 2024

Thanks

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
@oshoval oshoval mentioned this pull request Sep 26, 2024
@kubevirt-bot kubevirt-bot merged commit 66eda52 into kubevirt:main Sep 26, 2024
15 checks passed
@oshoval
Copy link
Collaborator

oshoval commented Sep 26, 2024

btw seems hack/bump-kubevirtci.sh is broken, at least locally for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants