cleanup

kvargha · Feb 5, 2025 · d95c145 · d95c145
1 parent 96f1d51
commit d95c145
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/...inci-client/src/test/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTaskTest.java b/...inci-client/src/test/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTaskTest.java
@@ -4979,8 +4979,6 @@ public void testSITRecordTransformerError(AAConfig aaConfig) throws Exception {
 
     DaVinciRecordTransformerConfig recordTransformerConfig =
         new DaVinciRecordTransformerConfig.Builder().setRecordTransformerFunction(TestStringRecordTransformer::new)
-            .setOutputValueClass(String.class)
-            .setOutputValueSchema(Schema.create(Schema.Type.STRING))
             .build();
     config.setRecordTransformerConfig(recordTransformerConfig);
     runTest(config);

diff --git a/...nt/src/test/java/com/linkedin/davinci/transformer/DaVinciRecordTransformerConfigTest.java b/...nt/src/test/java/com/linkedin/davinci/transformer/DaVinciRecordTransformerConfigTest.java
@@ -75,7 +75,7 @@ public void testNonDefaults() {
   }
 
   @Test
-  public void testNotDefiningOutputValueClassAndSchema() {
+  public void testUndefinedOutputValueClassAndSchema() {
     DaVinciRecordTransformerConfig recordTransformerConfig =
         new DaVinciRecordTransformerConfig.Builder().setRecordTransformerFunction(TestStringRecordTransformer::new)
             .build();

diff --git a/docs/user_guide/read_api/da_vinci_client.md b/docs/user_guide/read_api/da_vinci_client.md
@@ -126,6 +126,7 @@ public class IntToStringRecordTransformer extends DaVinciRecordTransformer<Integ
 }
 ```
 
+Here's an example `DaVinciRecordTransformerConfig` implementation:
 ```
 DaVinciRecordTransformerConfig recordTransformerConfig =
         new DaVinciRecordTransformerConfig.Builder()
-Original file line number
+Diff line change
@@ Expand Up @@
     }
     ```
+    Here's an example `DaVinciRecordTransformerConfig` implementation:
     ```
     DaVinciRecordTransformerConfig recordTransformerConfig =
             new DaVinciRecordTransformerConfig.Builder()
@@ Expand Down @@