Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make "claims" of "ClaimSet" readable #99

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

make "claims" of "ClaimSet" readable #99

wants to merge 5 commits into from

Conversation

Wooder
Copy link

@Wooder Wooder commented Jan 20, 2018

As discussed in #69 in some cases
access to the raw json data is needed. Therefore „claims“ should be
exposed.

@jholzerinovex
make claims readable
d788d07 
As described in issue
kylef#69 in some cases
access to the raw json data is needed. Therefore „claims“ should be
exposed.
@jholzerinovex
change setter of "claims" to internal
793c5d5
@Wooder Wooder mentioned this pull request Jan 20, 2018
Open
@chadmoone
Copy link

I totally missed this before creating #106, which is a slightly different approach to the same thing. Personally, I don't see why set should be internal, though my primary concern is also with the ability to read it publicly.

@kylef Do you have a preference? Any chance we can get one of these in?

@jonblatho jonblatho mentioned this pull request Jul 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wooder @chadmoone @jholzerinovex