Skip to content

fix: Add missing ansible_check_mode condition in remaining_nodes.yml#363

Merged
MonolithProjects merged 1 commit intolablabs:mainfrom
nikitamishagin:fix/check-mode
Oct 3, 2025
Merged

fix: Add missing ansible_check_mode condition in remaining_nodes.yml#363
MonolithProjects merged 1 commit intolablabs:mainfrom
nikitamishagin:fix/check-mode

Conversation

@nikitamishagin
Copy link
Contributor

Description

This change adds a missing check-mode guard to the readiness wait tasks. When the role was executed with Ansible check mode (-C), those tasks could enter an infinite loop because the cluster state is not actually changing and the readiness conditions could never be met.

What’s changed:

  • The readiness wait logic is now skipped in check mode, preventing indefinite retries.
  • Normal (non-check-mode) runs are unaffected and continue to wait for nodes as expected.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small minor change not affecting the Ansible Role code (GitHub Actions Workflow, Documentation etc.)

How Has This Been Tested?

  • Reproduced the hang by running the role with -C before the change.
  • Verified that after the change, check-mode runs complete without hanging.
  • Confirmed that regular runs still wait for readiness and succeed as before.

@MonolithProjects MonolithProjects self-assigned this Sep 25, 2025
@MonolithProjects MonolithProjects added the bug Something isn't working label Sep 25, 2025
Copy link
Collaborator

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@MonolithProjects MonolithProjects merged commit d5b7301 into lablabs:main Oct 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants