fix: Add missing ansible_check_mode condition in remaining_nodes.yml#363
Merged
MonolithProjects merged 1 commit intolablabs:mainfrom Oct 3, 2025
nikitamishagin:fix/check-mode
Merged
fix: Add missing ansible_check_mode condition in remaining_nodes.yml#363MonolithProjects merged 1 commit intolablabs:mainfrom nikitamishagin:fix/check-mode
MonolithProjects merged 1 commit intolablabs:mainfrom
nikitamishagin:fix/check-mode
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds a missing check-mode guard to the readiness wait tasks. When the role was executed with Ansible check mode (-C), those tasks could enter an infinite loop because the cluster state is not actually changing and the readiness conditions could never be met.
What’s changed:
Type of change
How Has This Been Tested?