Skip to content

feat(rke2): support structured configuration options#364

Merged
MonolithProjects merged 1 commit intolablabs:mainfrom
anjia0532:feat/config_options_enhance
Oct 3, 2025
Merged

feat(rke2): support structured configuration options#364
MonolithProjects merged 1 commit intolablabs:mainfrom
anjia0532:feat/config_options_enhance

Conversation

@anjia0532
Copy link
Contributor

  • Add conditional handling for mapping-type options
  • Enable key-value pair rendering for server options
  • Enable key-value pair rendering for agent options
  • Enable key-value pair rendering for environment options
  • Maintain backward compatibility with string options
  • Improve template logic for configuration generation

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small minor change not affecting the Ansible Role code (GitHub Actions Workflow, Documentation etc.)

How Has This Been Tested?

The original syntax is list string (doc https://github.com/lablabs/ansible-role-rke2/blob/main/README.md?plain=1#L301-L317)

# e.g. 
rke2_server_options:
  - "option: value"
rke2_agent_options:
  - "option: value"
rke2_environment_options:
  - "option: value"

The new syntax support list string and list object

# e.g.
rke2_server_options:
  - "option1: value"
  - option2: value2

- Add conditional handling for mapping-type options
- Enable key-value pair rendering for server options
- Enable key-value pair rendering for agent options
- Maintain backward compatibility with string options
- Improve template logic for configuration generation
@MonolithProjects MonolithProjects self-assigned this Oct 3, 2025
@MonolithProjects MonolithProjects added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Oct 3, 2025
Copy link
Collaborator

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@MonolithProjects MonolithProjects merged commit 5bea9c8 into lablabs:main Oct 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants