Skip to content

feat: RKE2 etcd object storage configuration#376

Merged
MonolithProjects merged 1 commit intolablabs:mainfrom
world-direct:feat/etcd_s3
Dec 19, 2025
Merged

feat: RKE2 etcd object storage configuration#376
MonolithProjects merged 1 commit intolablabs:mainfrom
world-direct:feat/etcd_s3

Conversation

@hwo-wd
Copy link
Contributor

@hwo-wd hwo-wd commented Dec 2, 2025

Description

Building upon prior work1, this adds the configuration options for persisting snapshots to object storage as per the docs.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small minor change not affecting the Ansible Role code (GitHub Actions Workflow, Documentation etc.)

How Has This Been Tested?

Manual execution and cross-checking the object store.

Footnotes

  1. up to now, "only" restoring from etcd snapshot@S3 was possible.

@hwo-wd
Copy link
Contributor Author

hwo-wd commented Dec 3, 2025

@MonolithProjects thanks for looking into this PR; as far as I can tell, the error stem from previous issues already residing in main:

@MonolithProjects
Copy link
Collaborator

Thanks @hwo-wd for your PR. I will check it bit later. The failed tests does not seem to be related to your change, so you non't need to bother with them 🙂

@MonolithProjects MonolithProjects added the enhancement New feature or request label Dec 19, 2025
Copy link
Collaborator

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@MonolithProjects MonolithProjects merged commit a308108 into lablabs:main Dec 19, 2025
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants