fix: use id as a key of Image

lablup · Sep 11, 2024 · 2023cd5 · 2023cd5
1 parent 9d0dd72
commit 2023cd5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/react/src/components/ImageEnvironmentSelectFormItems.tsx b/react/src/components/ImageEnvironmentSelectFormItems.tsx
@@ -101,6 +101,7 @@ const ImageEnvironmentSelectFormItems: React.FC<
     graphql`
       query ImageEnvironmentSelectFormItemsQuery($installed: Boolean) {
         images(is_installed: $installed) {
+          id
           name
           humanized_name
           tag
@@ -562,7 +563,7 @@ const ImageEnvironmentSelectFormItems: React.FC<
                 }
               >
                 {_.map(
-                  _.uniqBy(selectedEnvironmentGroup?.images, 'digest'),
+                  _.uniqBy(selectedEnvironmentGroup?.images, 'id'),
 
                   (image) => {
                     const [version, tag, ...requirements] = image?.tag?.split(
@@ -658,7 +659,7 @@ const ImageEnvironmentSelectFormItems: React.FC<
                     }
                     return (
                       <Select.Option
-                        key={image?.digest}
+                        key={image?.id}
                         value={getImageFullName(image)}
                         filterValue={[
                           version,

diff --git a/react/src/components/ResourceAllocationFormItems.test.ts b/react/src/components/ResourceAllocationFormItems.test.ts
@@ -35,6 +35,7 @@ describe('getAllocatablePresetNames', () => {
   };
 
   const image_has_cuda_shares_min1_max1: Image = {
+    id: 'id1',
     name: 'image1',
     digest: 'digest1',
     architecture: 'arm64',