Apply suggestions from code review

lablup · Feb 19, 2025 · 4db418f · 4db418f
1 parent e88aa59
commit 4db418f
Showing 1 changed file with 19 additions and 14 deletions.
diff --git a/react/src/components/AutoScalingRuleEditorModal.tsx b/react/src/components/AutoScalingRuleEditorModal.tsx
@@ -264,7 +264,6 @@ const AutoScalingRuleEditorModal: React.FC<AutoScalingRuleEditorModalProps> = ({
                 type: 'up',
                 metric_source: 'KERNEL',
                 comparator: 'GREATER_THAN',
-                // threshold: '',
                 step_size: 1,
                 cooldown_seconds: 300,
                 min_replicas: 0,
@@ -280,21 +279,11 @@ const AutoScalingRuleEditorModal: React.FC<AutoScalingRuleEditorModalProps> = ({
           <Radio.Group
             options={[
               {
-                label: (
-                  <Flex gap={'xs'}>
-                    {t('autoScalingRule.ScaleUp')}
-                    {/* <MoveUpRight /> */}
-                  </Flex>
-                ),
+                label: <Flex gap={'xs'}>{t('autoScalingRule.ScaleUp')}</Flex>,
                 value: 'up',
               },
               {
-                label: (
-                  <Flex gap={'xs'}>
-                    {t('autoScalingRule.ScaleDown')}
-                    {/* <MoveDownRight /> */}
-                  </Flex>
-                ),
+                label: <Flex gap={'xs'}>{t('autoScalingRule.ScaleDown')}</Flex>,
                 value: 'down',
               },
             ]}
@@ -377,7 +366,7 @@ const AutoScalingRuleEditorModal: React.FC<AutoScalingRuleEditorModalProps> = ({
                     options={_.map(COMPARATOR_LABELS, (label, value) => ({
                       label: (
                         <Flex gap={'xs'}>
-                          {label}{' '}
+                          {label}
                           <Typography.Text type="secondary">
                             ({value})
                           </Typography.Text>
@@ -411,6 +400,16 @@ const AutoScalingRuleEditorModal: React.FC<AutoScalingRuleEditorModalProps> = ({
               min: 1,
               max: SIGNED_32BIT_MAX_INT,
             },
+            {
+              validator: (_, value) => {
+                if (value % 1 !== 0) {
+                  return Promise.reject(
+                    new Error(t('error.OnlyPositiveIntegersAreAllowed')),
+                  );
+                }
+                return Promise.resolve();
+              },
+            },
           ]}
         >
           <InputNumber min={1} step={1} style={{ width: '100%' }} />
@@ -425,6 +424,8 @@ const AutoScalingRuleEditorModal: React.FC<AutoScalingRuleEditorModalProps> = ({
                 rules={[
                   {
                     required: true,
+                  },
+                  {
                     min: 0,
                     max: SIGNED_32BIT_MAX_INT,
                     type: 'number',
@@ -455,6 +456,8 @@ const AutoScalingRuleEditorModal: React.FC<AutoScalingRuleEditorModalProps> = ({
                 rules={[
                   {
                     required: true,
+                  },
+                  {
                     min: 0,
                     max: SIGNED_32BIT_MAX_INT,
                     type: 'number',
@@ -486,6 +489,8 @@ const AutoScalingRuleEditorModal: React.FC<AutoScalingRuleEditorModalProps> = ({
           rules={[
             {
               required: true,
+            },
+            {
               min: 0,
               type: 'number',
             },