feat: migrate user credential list to react component #2758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 18, 2024
ironAiken2
force-pushed
the
feat/user-credential-list
branch
from
469be25 to
7e699f3
Compare
yomybaby
force-pushed
the
feat/user-list-page
branch
2 times, most recently
from
1f06be9 to
42880b8
Compare
yomybaby
force-pushed
the
feat/user-credential-list
branch
from
7e699f3 to
bfdb3c2
Compare
ironAiken2
force-pushed
the
feat/user-list-page
branch
from
42880b8 to
938d531
Compare
ironAiken2
force-pushed
the
feat/user-credential-list
branch
from
bfdb3c2 to
8703467
Compare
ironAiken2
force-pushed
the
feat/user-list-page
branch
from
938d531 to
747bd07
Compare
ironAiken2
force-pushed
the
feat/user-credential-list
branch
from
8703467 to
1890954
Compare
yomybaby
force-pushed
the
feat/user-list-page
branch
from
747bd07 to
11e7f67
Compare
ironAiken2
force-pushed
the
feat/user-list-page
branch
from
11e7f67 to
b375e78
Compare
ironAiken2
force-pushed
the
feat/user-credential-list
branch
from
1890954 to
4c31b0e
Compare
ironAiken2
changed the base branch from
feat/user-list-page
to
feature/user-node-list
ironAiken2
force-pushed
the
feature/user-node-list
branch
from
b3f2278 to
a9d0ece
Compare
ironAiken2
force-pushed
the
feat/user-credential-list
branch
from
4c31b0e to
3b84f85
Compare
ironAiken2
force-pushed
the
feat/user-credential-list
branch
2 times, most recently
from
654ed07 to
bc1063b
Compare
ironAiken2
force-pushed
the
feat/user-credential-list
branch
from
d5cdf0d to
2dd1233
Compare
6 tasks
ironAiken2
force-pushed
the
feat/user-credential-list
branch
from
2dd1233 to
6c501cb
Compare
agatha197
requested changes
Dec 18, 2024
ironAiken2
force-pushed
the
feat/user-credential-list
branch
from
6c501cb to
8c68ea6
Compare
agatha197
requested changes
Dec 18, 2024
ironAiken2
force-pushed
the
feat/user-credential-list
branch
from
8c68ea6 to
a35f9a8
Compare
agatha197
requested changes
Dec 18, 2024
Instead of showing the main access key information in the table, we decided to show it in the info modal. |
agatha197
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Is it possible to remove the main access key? If not, it needs to be disabled. @ironAiken2
Since we don't know the main access key information, we decided to display an error message instead of button disabled. |
agatha197
requested changes
Dec 18, 2024
ironAiken2
force-pushed
the
feat/user-credential-list
branch
2 times, most recently
from
8b8138c to
ad3c66f
Compare
ironAiken2
force-pushed
the
feat/user-credential-list
branch
2 times, most recently
from
6405a37 to
642664f
Compare
ironAiken2
force-pushed
the
feat/user-credential-list
branch
from
642664f to
5490140
Compare
6 tasks
Merge activity
|
<!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> ### This PR resolves [#2937](#2937) Issue The keypair info/modify/create modal will be working on a separate stack. **Chages:** - migrate keypair list to react component **How to test:** - Verify that keypair list is �working correctly.  **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
yomybaby
force-pushed
the
feat/user-credential-list
branch
from
5490140 to
e07e4bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2937 Issue
The keypair info/modify/create modal will be working on a separate stack.
Chages:
How to test:
Checklist: (if applicable)