Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing container registry types #2913

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Dec 2, 2024

Fixes #2904.

Minium required manager version: 24.09

2024-12-02_21-37-09 png

Checklist: (if applicable)

  • Mention to the original issue
  • Minium required manager version

Copy link

graphite-app bot commented Dec 2, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the size:S 10~30 LoC label Dec 2, 2024
@jopemachine jopemachine added this to the 24.09 milestone Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 5.21% 395/7575
🔴 Branches 4.53% 237/5229
🔴 Functions 3.12% 78/2497
🔴 Lines 5.13% 380/7406

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from bd450b2

@jopemachine jopemachine requested a review from yomybaby December 2, 2024 12:45
@jopemachine jopemachine marked this pull request as ready for review December 2, 2024 12:47
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Dec 3, 2024

Merge activity

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

Fixes #2904.

Minium required manager version: 24.09

<img width="681" alt="2024-12-02_21-37-09 png" src="https://github.com/user-attachments/assets/60c0f1e2-1f46-458b-81f9-1abcb989d890">

**Checklist:** (if applicable)

- [x] Mention to the original issue
- [x] Minium required manager version
@yomybaby yomybaby force-pushed the fix/add-missing-cr-types branch from c01dd14 to bd450b2 Compare December 3, 2024 02:05
@graphite-app graphite-app bot merged commit bd450b2 into main Dec 3, 2024
6 checks passed
@graphite-app graphite-app bot deleted the fix/add-missing-cr-types branch December 3, 2024 02:06
@yomybaby yomybaby requested review from ironAiken2 and removed request for ironAiken2 December 5, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing container registry types to modal
2 participants