Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Add flex-wrap and tag resource group text for improved readability. #2954

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Dec 13, 2024

resolves #2955

Changes:
Enhances the session detail view by wrapping the resource allocation section and displaying the scaling group inside a Tag component for better visual hierarchy and consistency.

Impact:
Users will see a clearer, more visually distinct scaling group indicator in the session details, with improved wrapping behavior for resource allocation information.

Before:

image.png

After:

image.png

Checklist:

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the size:XS ~10 LoC label Dec 13, 2024
@agatha197 agatha197 added area:ux UI / UX issue. effort:easy Need to understand only a specific region of codes (good first issue, easy). field:UI / UX urgency:1 If no other duties are available, volunteer to help. labels Dec 13, 2024 — with Graphite App
Copy link

github-actions bot commented Dec 13, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 5.2% 398/7652
🔴 Branches 4.45% 237/5323
🔴 Functions 3.1% 78/2519
🔴 Lines 5.12% 383/7483

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from bbd8696

Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Dec 16, 2024

Merge activity

…lity. (#2954)

resolves #2955

**Changes:**
Enhances the session detail view by wrapping the resource allocation section and displaying the scaling group inside a Tag component for better visual hierarchy and consistency.

**Impact:**
Users will see a clearer, more visually distinct scaling group indicator in the session details, with improved wrapping behavior for resource allocation information.

**Before:**

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/a9275bb6-3123-420b-b47e-1007aab51d67.png)

**After:**

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/7a413e0a-8afc-4b5f-b9d6-ce0a89b95818.png)

**Checklist:**
- [ ] Mention to the original issue
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@yomybaby yomybaby force-pushed the style/add-flex-wrap-to-resource-group branch from 18492ae to bbd8696 Compare December 16, 2024 03:34
@graphite-app graphite-app bot merged commit bbd8696 into main Dec 16, 2024
6 checks passed
@graphite-app graphite-app bot deleted the style/add-flex-wrap-to-resource-group branch December 16, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ux UI / UX issue. effort:easy Need to understand only a specific region of codes (good first issue, easy). field:UI / UX size:XS ~10 LoC urgency:1 If no other duties are available, volunteer to help.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flex-wrap style to resource group tags for improved readability
2 participants