Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update NVIDIA references in image metadata #2971

Merged

Conversation

rapsealk
Copy link
Member

@rapsealk rapsealk commented Dec 20, 2024

Changes:
Updated all instances of "Nvidia" to "NVIDIA" in GPU Cloud references across image metadata and test files to maintain consistent branding with NVIDIA's official capitalization.

The correct way of writing NVIDIA is in all uppercase letters.

Rationale:
Ensures proper brand name representation and consistency with NVIDIA's corporate identity guidelines.

Ref

Checklist:

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added the size:M 30~100 LoC label Dec 20, 2024
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rapsealk rapsealk marked this pull request as ready for review December 20, 2024 04:53
Copy link

github-actions bot commented Dec 20, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 5.2% 398/7652
🔴 Branches 4.45% 237/5323
🔴 Functions 3.1% 78/2519
🔴 Lines 5.12% 383/7483

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from fafc6c2

@rapsealk rapsealk force-pushed the 12-20-chore_update_nvidia_reference_in_image_metadata branch from 3d6a35f to fafc6c2 Compare December 20, 2024 06:28
@rapsealk rapsealk changed the title chore: update NVIDIA reference in image metadata chore: update NVIDIA references in image metadata Dec 20, 2024
@rapsealk rapsealk requested a review from yomybaby December 20, 2024 15:24
@rapsealk rapsealk added this to the 24.09 milestone Dec 20, 2024
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Dec 23, 2024

Merge activity

**Changes:**
Updated all instances of "Nvidia" to "NVIDIA" in GPU Cloud references across image metadata and test files to maintain consistent branding with NVIDIA's official capitalization.

> The correct way of writing NVIDIA is in all uppercase letters.

**Rationale:**
Ensures proper brand name representation and consistency with NVIDIA's corporate identity guidelines.

Ref
- https://http.download.nvidia.com/image_kit/LG_NVCorpBadge.pdf

**Checklist:**
- [ ] Mention to the original issue
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@yomybaby yomybaby force-pushed the 12-20-chore_update_nvidia_reference_in_image_metadata branch from fafc6c2 to d5b3518 Compare December 23, 2024 09:09
@graphite-app graphite-app bot merged commit d5b3518 into main Dec 23, 2024
5 of 6 checks passed
@graphite-app graphite-app bot deleted the 12-20-chore_update_nvidia_reference_in_image_metadata branch December 23, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants