feat(FR-534): introduce NEO style Tabs and RadioGroup #3139
+250
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.62% (-0.01% 🔻) |
401/8689 |
| 🔴 | Branches | 4% (-0% 🔻) |
239/5980 |
| 🔴 | Functions | 2.79% (-0% 🔻) |
78/2796 |
| 🔴 | Lines | 4.54% (-0.01% 🔻) |
386/8500 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / BAIRadioGroup.tsx |
0% | 100% | 0% | 0% |
| 🔴 | ... / BAITabs.tsx |
0% | 100% | 0% | 0% |
| 🔴 | ... / EndpointList.tsx |
0% | 0% | 0% | 0% |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 03a9536
yomybaby
force-pushed
the
feature/baitabs-and-bairadiogroup
branch
3 times, most recently
from
2d39a5c to
0a66706
Compare
yomybaby
force-pushed
the
feature/baitabs-and-bairadiogroup
branch
from
0a66706 to
17fade8
Compare
yomybaby
changed the title
yomybaby
force-pushed
the
feature/baitabs-and-bairadiogroup
branch
from
17fade8 to
2f135b1
Compare
agatha197
requested changes
Feb 17, 2025
yomybaby
force-pushed
the
feature/baitabs-and-bairadiogroup
branch
from
2f135b1 to
4fabfd4
Compare
|
@agatha197 resolved! 😀 |
agatha197
requested changes
Feb 20, 2025
| @@ -163,6 +164,8 @@ const BAITable = <RecordType extends object = any>({ | |||
| !isDarkMode && neoStyle | |||
| ? { | |||
| headerBg: '#E3E3E3', | |||
| headerSplitColor: token.colorTextQuaternary, | |||
| // headerSplitColor: token.colorTextQuaternary | |||
There was a problem hiding this comment.
Suggested change
| // headerSplitColor: token.colorTextQuaternary |
yomybaby
force-pushed
the
feature/baitabs-and-bairadiogroup
branch
from
4fabfd4 to
13be49a
Compare
5 tasks
yomybaby
force-pushed
the
feature/baitabs-and-bairadiogroup
branch
from
13be49a to
03a9536
Compare
agatha197
requested changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3182 (FR-534)
resolves #3182 (FR-534)
Introduces new UI components and enhances existing ones to improve visual consistency and user experience: