Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FR): Move LLM Playground to on the top menu #3167

Closed
wants to merge 3 commits into from

Conversation

ragingwind
Copy link
Contributor

@ragingwind ragingwind commented Feb 14, 2025

resolves #NNN (FR-536)

Adds a dedicated Chat page accessible from the main navigation menu. The chat functionality has been moved from the Serving page to its own route at /chat. This change includes:

  • New Chat menu item in the main navigation sidebar
  • Relocated chat components from lablupTalkativotUI to a dedicated Chat directory
  • Added chat-related translations for all supported languages
  • Simplified the initial chat interface to start with a single chat window instead of two

Copy link

cla-assistant bot commented Feb 14, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Feb 14, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ragingwind ragingwind marked this pull request as ready for review February 14, 2025 08:18
@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization labels Feb 14, 2025
Copy link
Contributor Author

ragingwind commented Feb 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added size:L 100~500 LoC area:lib Library and SDK related issue. size:XL 500~ LoC and removed size:L 100~500 LoC labels Feb 14, 2025
ragingwind and others added 3 commits February 17, 2025 11:06
resolves #3138 (FR-503)

Added a container log viewer button to the connected kernel list. Users can now directly view container logs for each kernel by clicking the log icon next to the kernel ID, which opens a modal displaying the container logs.

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/XqC2uNFuj0wg8I60sMUh/8ed2137c-59ab-4d84-baeb-80f2ecf44f28.png)
resolves #3137 (FR-502)

Introduces a new `UnmountModalAfterClose` component that properly unmounts modal components after they close, preventing unnecessary re-renders and memory leaks. The component is implemented in the `ConnectedKernelList` to manage the `ContainerLogModal`.

The new component:
- Tracks modal open/close state internally
- Preserves original `afterClose` callbacks
- Only renders the modal when needed
- Handles cleanup after modal animations complete
@ragingwind ragingwind force-pushed the 02-14-add_chat_page_on_the_top branch from eebcc08 to c7fde46 Compare February 17, 2025 02:08
@github-actions github-actions bot added size:L 100~500 LoC and removed size:XL 500~ LoC labels Feb 17, 2025
Copy link

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 4.67% 400/8561
🔴 Branches
4.05% (+0% 🔼)
239/5895
🔴 Functions 2.83% 78/2752
🔴 Lines
4.6% (+0% 🔼)
385/8377
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴 pages/ChatPage.tsx 0% 0% 0% 0%
🔴
... / ScrollBottomHandlerButton.tsx
0% 0% 0% 0%
🔴
... / ChatMessageList.tsx
0% 0% 0% 0%
🔴
... / ChatSender.tsx
0% 0% 0% 0%
🔴
... / ModelSelect.tsx
0% 0% 0% 0%
🔴
... / ChatMessage.tsx
0% 0% 0% 0%
🔴
... / CopyButton.tsx
0% 0% 0% 0%
🔴
... / EndpointLLMChatCard.tsx
0% 0% 0% 0%
🔴
... / VirtualChatMessageList.tsx
0% 0% 0% 0%
🔴
... / LLMChatCard.tsx
0% 0% 0% 0%
🔴
... / ChatUIModal.tsx
0% 0% 0% 0%
🔴
... / ChatMessageContent.tsx
0% 0% 0% 0%

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from c7fde46

@ragingwind ragingwind changed the title add chat page on the top feat(FR-536): add chat page on the top Feb 17, 2025
@ragingwind ragingwind changed the title feat(FR-536): add chat page on the top feat(FR-536): Move LLM Playground to on the top menu Feb 17, 2025
@ragingwind ragingwind requested a review from yomybaby February 17, 2025 05:28
This was referenced Feb 17, 2025
@ragingwind ragingwind changed the title feat(FR-536): Move LLM Playground to on the top menu feat(FR): Move LLM Playground to on the top menu Feb 18, 2025
@ragingwind ragingwind closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:lib Library and SDK related issue. area:ux UI / UX issue. size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants