Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FR-252): Introduce session status info modal in session detail panel #3190

Open
wants to merge 1 commit into
base: feat/icon-components
Choose a base branch
from

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Feb 17, 2025

resolves #NNN (FR-252)

Adds a detailed session status modal that displays kernel exit codes, session status, predicate checks, and error information. The modal can be accessed by clicking on the session status tag when additional status data is available.

Key changes:

  • Added new SessionStatusDetailModal component to show comprehensive session status information
  • Enhanced SessionStatusTag to display a clickable status indicator with detailed information
  • Added translations for new status-related strings across all supported languages
  • Updated status tag styling to better indicate when additional details are available

How to test:

  • If a session have status data, the status description tag in the session detail panel displays a '?' icon. Click on that tag to open the status detail modal.
  • Each error has the following classifications kernel error, session error, scheduler, error.
  • You can test it on dogbowl.

Checklist:

  • Documentation
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added the size:S 10~30 LoC label Feb 17, 2025
Copy link
Contributor Author

ironAiken2 commented Feb 17, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Feb 17, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.59% (-0.03% 🔻)
401/8741
🔴 Branches
3.97% (-0.03% 🔻)
239/6018
🔴 Functions
2.76% (-0.03% 🔻)
78/2821
🔴 Lines
4.51% (-0.03% 🔻)
386/8555
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / SessionStatusDetailModal.tsx
0% 0% 0% 0%
🔴
... / CalculateResourceIcon.tsx
0% 100% 0% 0%
🔴
... / ShareAltIcon.tsx
0% 100% 0% 0%
🔴
... / RestoreIcon.tsx
0% 100% 0% 0%
🔴
... / EndpointIcon.tsx
0% 100% 0% 0%
🔴
... / ListIcon.tsx
0% 100% 0% 0%
🔴
... / AppIcon.tsx
0% 100% 0% 0%
🔴
... / NewFolderIcon.tsx
0% 100% 0% 0%
🔴
... / TerminateIcon.tsx
0% 100% 0% 0%
🔴
... / SessionLogIcon.tsx
0% 100% 0% 0%
🔴
... / UserUnionIcon.tsx
0% 100% 0% 0%
🔴
... / StartCircleIcon.tsx
0% 100% 0% 0%
🔴
... / PipelineIcon.tsx
0% 100% 0% 0%
🔴
... / DashboardIcon.tsx
0% 100% 0% 0%
🔴
... / RescanImagesIcon.tsx
0% 100% 0% 0%
🔴
... / ContainerCommitIcon.tsx
0% 100% 0% 0%
🔴
... / SessionStartIcon.tsx
0% 100% 0% 0%
🔴
... / TerminalAppIcon.tsx
0% 100% 0% 0%
🔴
... / PurgeIcon.tsx
0% 100% 0% 0%
🔴
... / SystemMonitorIcon.tsx
0% 100% 0% 0%
🔴
... / UploadIcon.tsx
0% 100% 0% 0%
🔴
... / TrashBinIcon.tsx
0% 100% 0% 0%
🔴
... / ModelStoreIcon.tsx
0% 100% 0% 0%
🔴
... / ChatMessageList.tsx
0% 0% 0% 0%
🔴
... / ScrollBottomHandlerButton.tsx
0% 0% 0% 0%
🔴
... / ChatSender.tsx
0% 0% 0% 0%
🔴
... / ChatMessage.tsx
0% 0% 0% 0%
🔴
... / ModelSelect.tsx
0% 0% 0% 0%
🔴
... / CopyButton.tsx
0% 0% 0% 0%
🔴
... / LLMChatCard.tsx
0% 0% 0% 0%
🔴
... / ChatUIModal.tsx
0% 0% 0% 0%
🔴
... / VirtualChatMessageList.tsx
0% 0% 0% 0%
🔴
... / EndpointLLMChatCard.tsx
0% 0% 0% 0%
🔴
... / ChatMessageContent.tsx
0% 0% 0% 0%
🔴
... / LLMPlaygroundPage.tsx
0% 0% 0% 0%

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 6d79bf1

@ironAiken2 ironAiken2 force-pushed the feat/session-status-info-modal branch from 0d6c2a4 to a17ab8b Compare February 19, 2025 07:02
@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization size:L 100~500 LoC and removed size:S 10~30 LoC labels Feb 19, 2025
@ironAiken2 ironAiken2 changed the title feat: Introduce session status info modal in session detail panel feat(FR-252): Introduce session status info modal in session detail panel Feb 19, 2025
@ironAiken2 ironAiken2 marked this pull request as ready for review February 19, 2025 07:16
@ironAiken2 ironAiken2 force-pushed the feat/session-status-info-modal branch 4 times, most recently from a81a8a3 to 6d79bf1 Compare February 20, 2025 06:27
@ironAiken2 ironAiken2 changed the base branch from main to feat/icon-components February 20, 2025 06:27
@ironAiken2 ironAiken2 force-pushed the feat/session-status-info-modal branch from 6d79bf1 to 7509a1e Compare February 20, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:ux UI / UX issue. size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant