Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FR-547): fix calculate logic for agent list memory usage progress percent #3197

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Feb 18, 2025

resolves #3196 (FR-547)

Fixed memory utilization display in agent list by multiplying the ratio by 100 to show correct percentage values in the progress bar.

Checklist:

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ironAiken2 ironAiken2 marked this pull request as ready for review February 18, 2025 06:48
Copy link

github-actions bot commented Feb 18, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 4.63% 401/8659
🔴 Branches 4.02% 239/5944
🔴 Functions 2.8% 78/2788
🔴 Lines 4.56% 386/8473

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 79ed293

Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Feb 18, 2025

Merge activity

… percent (#3197)

resolves #3196 (FR-547)

Fixed memory utilization display in agent list by multiplying the ratio by 100 to show correct percentage values in the progress bar.

**Checklist:**
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@graphite-app graphite-app bot force-pushed the fix/progress-bar-in-agent-list branch from ece9052 to 79ed293 Compare February 18, 2025 07:22
@graphite-app graphite-app bot merged commit 79ed293 into main Feb 18, 2025
7 checks passed
@graphite-app graphite-app bot deleted the fix/progress-bar-in-agent-list branch February 18, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress bar display for memory usage in AgentList is not accurate
2 participants