Daily Test Coverage Improver - Fix coverage steps configuration#7924
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Daily Test Coverage Improver - Fix coverage steps configuration#7924github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…ands The --coverageDirectory option is not valid in vitest 4.x. Coverage output directory is configured via vitest.config.ts with the reportsDirectory setting, which is already set to 'coverage' for both React and backend.ai-ui projects. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed invalid vitest CLI options in the coverage steps action that were causing test runs to fail.
Problem
The action.yml was using
--coverageDirectoryoption which is not valid in vitest 4.x:Solution
Removed the
--coverageDirectoryoption from both React and backend.ai-ui test commands. The coverage output directory is already properly configured invitest.config.tsfiles via thereportsDirectory: 'coverage'setting.Changes
--coverageDirectory=coveragefrom React test command--coverageDirectory=coveragefrom backend.ai-ui test commandcoverage/directories as configuredVerification
The fix aligns with the vitest configuration:
react/vitest.config.tssetsreportsDirectory: 'coverage'What Happens Next
Once this PR is merged: