fix(FR-3204): keep model project folder mount permission read-only in Folder Explorer#8034
Open
nowgnuesLee wants to merge 1 commit into
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage Report for react-coverage (./react)
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
nowgnuesLee
force-pushed
the
06-24-fix_fr-3204_keep_model_project_folder_mount_permission_read-only_in_folder_explorer
branch
from
213a6b5 to
ddad0d2
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns Folder Explorer mount-permission editing behavior with the existing model project folder creation restriction (forced read-only), preventing users from switching such folders back to read-write when the backend feature flag is enabled. It also improves label consistency by explicitly naming the field “Mount Permission” in the creation modal.
Changes:
- Disable the
rwmount-permission option for model project folders in Folder Explorer whenallow-only-ro-permission-for-model-project-folderis supported, with an explanatory tooltip. - Rename the create-modal permission label to
data.folders.MountPermissionfor consistency with Folder Explorer terminology.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| react/src/components/VFolderNodeDescriptionV2.tsx | Gates and disables the rw mount-permission option for model project folders (feature-flagged), adds tooltip explanation, and adds a defensive early-return in onChange. |
| react/src/components/FolderCreateModalV2.tsx | Updates the permission field label to “Mount Permission” using the existing i18n key. |
nowgnuesLee
force-pushed
the
06-24-fix_fr-3204_keep_model_project_folder_mount_permission_read-only_in_folder_explorer
branch
2 times, most recently
from
330741b to
a404b57
Compare
… Folder Explorer When a model folder is created into a project from the Model Store, the mount permission is forced to read-only (ro) at creation time (FolderCreateModalV2 / FR-1290). However, the Folder Explorer detail panel still let users switch that permission back to read-write (rw), bypassing the enforcement. Mirror the creation-time restriction in VFolderNodeDescriptionV2: disable the 'rw' mount-permission option for model project folders (usageMode === 'MODEL' && ownershipType === 'GROUP'), with a tooltip reusing the existing data.folders.ModelProjectFolderRestrictedToReadOnly message and a defensive onChange guard. The read-only restriction is enforced by all currently supported manager versions, so drop the now-redundant 'allow-only-ro-permission-for-model-project-folder' feature-flag gate from both the Folder Explorer and the creation modal. Also rename the folder-creation permission field label from data.Permission to data.folders.MountPermission for consistency with the Folder Explorer, since both refer to the mount permission.
nowgnuesLee
force-pushed
the
06-24-fix_fr-3204_keep_model_project_folder_mount_permission_read-only_in_folder_explorer
branch
from
a404b57 to
64d418d
Compare
agatha197
requested changes
Jun 24, 2026
agatha197
left a comment
agatha197
left a comment
Contributor
There was a problem hiding this comment.
Add more design intent comments after discussing with core team.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8033 (FR-3204)
Summary
When a model folder is created into a project from the Model Store, the mount permission is forced to read-only (
ro) at creation time (FolderCreateModalV2/ FR-1290). However, the Folder Explorer detail panel still let users switch that permission back to read-write (rw), bypassing the enforcement.Changes
VFolderNodeDescriptionV2.tsx— Disable therwmount-permission option for model project folders (metadata.usageMode === 'MODEL'&&accessControl.ownershipType === 'GROUP'). A tooltip on the disabled option explains why, reusing the existingdata.folders.ModelProjectFolderRestrictedToReadOnlymessage already shown in the create modal, plus a defensiveonChangeguard.FolderCreateModalV2.tsx— Rename the permission field label fromdata.Permission("권한") todata.folders.MountPermission("마운트 권한") for consistency with the Folder Explorer, since both refer to the mount permission. Also drop the now-redundant feature-flag gate (see below).allow-only-ro-permission-for-model-project-folderfeature-flag gate from both screens. The restriction is enforced by all currently supported manager versions (LTS ≥ 25.18.2), so the version gate was alwaystrue— a dead branch. Removing it from both call sites keeps the two screens consistent.Verification
bash scripts/verify.sh→ Relay / Lint / Format / TypeScript all PASS.(The pre-existing "Vite warmup paths" check fails on
mainas well, unrelated to this change.)Test plan
ro).rwoption is disabled and shows the read-only tooltip on hover; onlyrois selectable.roandrwremain selectable.