Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unexpected dates #11

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Handle unexpected dates #11

merged 2 commits into from
Apr 1, 2024

Conversation

xmedr
Copy link
Collaborator

@xmedr xmedr commented Mar 29, 2024

Overview

There were parsing errors coming from unexpected inputs in the termDate field. Examples of these inputs are 03312022, 0130/22, Not req'd to submit, on-going, or 045/15/21. This branch:

  • handles the first two cases, by formatting them as month/day/year
  • handles the cases with words, by making them lower case for standardization sake, and passing them through
  • notifies the user of the last case, but passes it through as is

Testing Instructions

  • Run make lm20.db and check for errors along the way
    • The process runs in github actions and this might be enough to satisfy this test

Xavier Medrano and others added 2 commits March 28, 2024 16:57
@xmedr xmedr marked this pull request as ready for review March 29, 2024 21:01
@xmedr xmedr requested a review from fgregg March 29, 2024 21:01
@xmedr xmedr merged commit a37b2e2 into main Apr 1, 2024
@xmedr xmedr deleted the fix/date-errors branch April 1, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants