Skip to content

fix: typos in documentation files #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use super::{
mod_circuit::{run_p_mod_circuit, run_p_mod_circuit_with_large_batch_size},
secp::{
ec_utils::{
compute_doubling_slope_external_consts, compute_slope_and_assing_secp_p,
compute_doubling_slope_external_consts, compute_slope_and_assign_secp_p,
ec_double_assign_new_y, ec_mul_inner, ec_negate_embedded_secp_p,
ec_negate_import_secp_p, square_slope_minus_xs,
},
Expand Down Expand Up @@ -553,7 +553,7 @@ impl HintProcessorLogic for BuiltinHintProcessor {
&hint_data.ids_data,
&hint_data.ap_tracking,
),
hint_code::COMPUTE_SLOPE_V1 => compute_slope_and_assing_secp_p(
hint_code::COMPUTE_SLOPE_V1 => compute_slope_and_assign_secp_p(
vm,
exec_scopes,
&hint_data.ids_data,
Expand All @@ -565,7 +565,7 @@ impl HintProcessorLogic for BuiltinHintProcessor {
hint_code::SQUARE_SLOPE_X_MOD_P => {
square_slope_minus_xs(vm, exec_scopes, &hint_data.ids_data, &hint_data.ap_tracking)
}
hint_code::COMPUTE_SLOPE_V2 => compute_slope_and_assing_secp_p(
hint_code::COMPUTE_SLOPE_V2 => compute_slope_and_assign_secp_p(
vm,
exec_scopes,
&hint_data.ids_data,
Expand Down Expand Up @@ -593,7 +593,7 @@ impl HintProcessorLogic for BuiltinHintProcessor {
"SECP256R1_P",
),
hint_code::IMPORT_SECP256R1_P => import_secp256r1_p(exec_scopes),
hint_code::COMPUTE_SLOPE_WHITELIST => compute_slope_and_assing_secp_p(
hint_code::COMPUTE_SLOPE_WHITELIST => compute_slope_and_assign_secp_p(
vm,
exec_scopes,
&hint_data.ids_data,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -954,7 +954,7 @@ mod tests {
dict: HashMap::from([(MaybeRelocatable::from(5), MaybeRelocatable::from((1, 7)))]),
default_value: MaybeRelocatable::from(2),
};
let expeced_dict_tracker = DictTracker {
let expected_dict_tracker = DictTracker {
data: expected_dict,
current_ptr: Relocatable::from((2, 3)),
};
Expand All @@ -965,7 +965,7 @@ mod tests {
.borrow()
.trackers
.get(&2),
Some(&expeced_dict_tracker)
Some(&expected_dict_tracker)
);
}
}
4 changes: 2 additions & 2 deletions vm/src/hint_processor/builtin_hint_processor/math_utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1684,7 +1684,7 @@ mod tests {

#[test]
#[cfg_attr(target_arch = "wasm32", wasm_bindgen_test)]
fn unsigned_div_rem_inconsitent_memory() {
fn unsigned_div_rem_inconsistent_memory() {
let hint_code = "from starkware.cairo.common.math_utils import assert_integer\nassert_integer(ids.div)\nassert 0 < ids.div <= PRIME // range_check_builtin.bound, \\\n f'div={hex(ids.div)} is out of the valid range.'\nids.q, ids.r = divmod(ids.value, ids.div)";
let mut vm = vm_with_range_check!();
//Initialize fp
Expand Down Expand Up @@ -1816,7 +1816,7 @@ mod tests {

#[test]
#[cfg_attr(target_arch = "wasm32", wasm_bindgen_test)]
fn signed_div_rem_inconsitent_memory() {
fn signed_div_rem_inconsistent_memory() {
let hint_code = "from starkware.cairo.common.math_utils import as_int, assert_integer\n\nassert_integer(ids.div)\nassert 0 < ids.div <= PRIME // range_check_builtin.bound, \\\n f'div={hex(ids.div)} is out of the valid range.'\n\nassert_integer(ids.bound)\nassert ids.bound <= range_check_builtin.bound // 2, \\\n f'bound={hex(ids.bound)} is out of the valid range.'\n\nint_value = as_int(ids.value, PRIME)\nq, ids.r = divmod(int_value, ids.div)\n\nassert -ids.bound <= q < ids.bound, \\\n f'{int_value} / {ids.div} = {q} is out of the range [{-ids.bound}, {ids.bound}).'\n\nids.biased_q = q + ids.bound";
let mut vm = vm_with_range_check!();
//Initialize fp
Expand Down
6 changes: 3 additions & 3 deletions vm/src/hint_processor/builtin_hint_processor/uint256_utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ pub fn uint256_unsigned_div_rem(
ids_data: &HashMap<String, HintReference>,
ap_tracking: &ApTracking,
) -> Result<(), HintError> {
uint256_offseted_unsigned_div_rem(vm, ids_data, ap_tracking, 0, 1)
uint256_offsetted_unsigned_div_rem(vm, ids_data, ap_tracking, 0, 1)
}

/*
Expand All @@ -363,10 +363,10 @@ pub fn uint256_expanded_unsigned_div_rem(
ids_data: &HashMap<String, HintReference>,
ap_tracking: &ApTracking,
) -> Result<(), HintError> {
uint256_offseted_unsigned_div_rem(vm, ids_data, ap_tracking, 1, 3)
uint256_offsetted_unsigned_div_rem(vm, ids_data, ap_tracking, 1, 3)
}

pub fn uint256_offseted_unsigned_div_rem(
pub fn uint256_offsetted_unsigned_div_rem(
vm: &mut VirtualMachine,
ids_data: &HashMap<String, HintReference>,
ap_tracking: &ApTracking,
Expand Down
2 changes: 1 addition & 1 deletion vm/src/hint_processor/hint_processor_utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ mod tests {

#[test]
#[cfg_attr(target_arch = "wasm32", wasm_bindgen_test)]
fn compute_addr_from_reference_no_regiter_in_reference() {
fn compute_addr_from_reference_no_register_in_reference() {
let mut vm = vm!();
vm.segments = segments![((1, 0), (4, 0))];
let mut hint_reference = HintReference::new(0, 0, false, false, true);
Expand Down