Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM] Added hints felt unpacking for blake. #1994 #2013

Closed
wants to merge 1 commit into from
Closed

[DNM] Added hints felt unpacking for blake. #1994 #2013

wants to merge 1 commit into from

Conversation

JulianGCalderon
Copy link
Contributor

Clone of #1994 to force CI to run.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 18, 2025 •
edited
Loading 

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     26.349 s ±  0.008 s    [User: 25.607 s, System: 0.740 s]
  Range (min … max):   26.343 s … 26.355 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     26.472 s ±  0.024 s    [User: 25.672 s, System: 0.798 s]
  Range (min … max):   26.455 s … 26.489 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.675 s ±  0.046 s    [User: 25.696 s, System: 0.809 s]
  Range (min … max):   14.642 s … 14.707 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.708 s ±  0.045 s    [User: 25.779 s, System: 0.765 s]
  Range (min … max):   14.676 s … 14.739 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.00 ± 0.00 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.661 s ±  0.455 s    [User: 38.934 s, System: 0.981 s]
  Range (min … max):   10.339 s … 10.982 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.650 s ±  0.185 s    [User: 37.799 s, System: 0.995 s]
  Range (min … max):   10.519 s … 10.781 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.00 ± 0.05 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.672 s ±  0.024 s    [User: 38.882 s, System: 0.969 s]
  Range (min … max):   10.655 s … 10.689 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.435 s ±  0.138 s    [User: 38.322 s, System: 0.975 s]
  Range (min … max):   10.337 s … 10.532 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.02 ± 0.01 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.501 s ±  0.099 s    [User: 39.135 s, System: 0.952 s]
  Range (min … max):   10.431 s … 10.571 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.399 s ±  0.182 s    [User: 38.509 s, System: 1.010 s]
  Range (min … max):   10.271 s … 10.528 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.01 ± 0.02 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.612 s ±  0.148 s    [User: 39.250 s, System: 1.050 s]
  Range (min … max):   10.507 s … 10.716 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.458 s ±  0.129 s    [User: 38.771 s, System: 1.087 s]
  Range (min … max):   10.367 s … 10.550 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.01 ± 0.02 times faster than hyper_threading_main threads: 16

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 18, 2025 •
edited
Loading

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.133 ± 0.026 2.108 2.199 1.00 ± 0.01
head big_factorial 2.128 ± 0.019 2.111 2.177 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.086 ± 0.028 2.057 2.157 1.01 ± 0.02
head big_fibonacci 2.062 ± 0.019 2.044 2.101 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.927 ± 0.103 7.818 8.126 1.01 ± 0.02
head blake2s_integration_benchmark 7.829 ± 0.083 7.765 8.034 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.188 ± 0.014 2.161 2.202 1.00
head compare_arrays_200000 2.198 ± 0.019 2.178 2.240 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.435 ± 0.014 1.416 1.456 1.00
head dict_integration_benchmark 1.437 ± 0.005 1.430 1.446 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.240 ± 0.004 1.231 1.245 1.01 ± 0.00
head field_arithmetic_get_square_benchmark 1.230 ± 0.003 1.225 1.235 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.008 ± 0.103 7.856 8.203 1.01 ± 0.01
head integration_builtins 7.905 ± 0.047 7.851 8.020 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.255 ± 0.091 8.183 8.495 1.01 ± 0.01
head keccak_integration_benchmark 8.179 ± 0.049 8.114 8.262 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.196 ± 0.015 2.170 2.223 1.00 ± 0.01
head linear_search 2.195 ± 0.021 2.174 2.247 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.519 ± 0.009 1.508 1.535 1.00
head math_cmp_and_pow_integration_benchmark 1.520 ± 0.014 1.509 1.558 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.469 ± 0.029 1.452 1.551 1.00 ± 0.02
head math_integration_benchmark 1.464 ± 0.011 1.457 1.492 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.220 ± 0.007 1.213 1.236 1.00
head memory_integration_benchmark 1.233 ± 0.027 1.218 1.307 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.603 ± 0.040 1.578 1.715 1.01 ± 0.03
head operations_with_data_structures_benchmarks 1.590 ± 0.014 1.576 1.626 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 540.7 ± 1.9 537.6 544.6 1.00 ± 0.01
head pedersen 540.5 ± 2.6 537.5 545.2 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 649.2 ± 1.8 646.0 651.7 1.00
head poseidon_integration_benchmark 651.3 ± 4.2 646.8 659.3 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.897 ± 0.025 1.875 1.949 1.01 ± 0.01
head secp_integration_benchmark 1.873 ± 0.005 1.868 1.882 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 685.9 ± 3.8 680.4 692.0 1.03 ± 0.01
head set_integration_benchmark 668.3 ± 6.0 660.0 680.1 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.319 ± 0.022 4.274 4.341 1.00 ± 0.01
head uint256_integration_benchmark 4.316 ± 0.031 4.280 4.393 1.00

@codecov Codecov
Copy link

codecov bot commented Mar 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.55%. Comparing base (9690634) to head (2882905).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2013      +/-   ##
==========================================
+ Coverage   96.54%   96.55%   +0.01%     
==========================================
  Files         102      102              
  Lines       42618    42747     +129     
==========================================
+ Hits        41145    41274     +129     
  Misses       1473     1473

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrancoGiachetta
Copy link
Contributor

The original PR was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JulianGCalderon @FrancoGiachetta @Alon-Ti