-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement New Executable API #2017
Draft
JulianGCalderon
wants to merge
38
commits into
main
Choose a base branch
from
new-executor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+798
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark Results for unmodified programs 🚀
|
69237f8
to
6be8f62
Compare
8e242c7
to
e789c53
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2017 +/- ##
==========================================
- Coverage 96.54% 96.53% -0.02%
==========================================
Files 102 102
Lines 42743 42729 -14
==========================================
- Hits 41268 41247 -21
- Misses 1475 1482 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
51b7e5c
to
6e5f40f
Compare
6e5f40f
to
6727a10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement New Executable API
This PR is a really early draft of the new executable API.
I've created a new structure
CairoRunner2
, and have been copied code from the original runner in order to test the new executable. The idea is to get a feel of how the new API should look like.My primary objective is to execute a simple program using the new runner. Once I get that working, I'll try to refactor the code in order to reuse code between the current API and the new API.
Checklist