Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep None memory cells for the prover input info #2021

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

Stavbe
Copy link
Collaborator

@Stavbe Stavbe commented Mar 24, 2025

Keep None memory cells for the prover input info.

Found a bug using the current version.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

This change is Reviewable

@Stavbe Stavbe marked this pull request as ready for review March 24, 2025 15:06
Copy link

github-actions bot commented Mar 24, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     26.295 s ±  0.042 s    [User: 25.522 s, System: 0.772 s]
  Range (min … max):   26.265 s … 26.324 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     26.364 s ±  0.058 s    [User: 25.601 s, System: 0.761 s]
  Range (min … max):   26.323 s … 26.405 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.608 s ±  0.042 s    [User: 25.593 s, System: 0.809 s]
  Range (min … max):   14.578 s … 14.638 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.641 s ±  0.074 s    [User: 25.666 s, System: 0.801 s]
  Range (min … max):   14.588 s … 14.693 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.00 ± 0.01 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.396 s ±  0.252 s    [User: 38.247 s, System: 0.960 s]
  Range (min … max):   10.218 s … 10.575 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.589 s ±  0.151 s    [User: 37.937 s, System: 0.927 s]
  Range (min … max):   10.482 s … 10.696 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.02 ± 0.03 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.346 s ±  0.011 s    [User: 38.084 s, System: 0.934 s]
  Range (min … max):   10.338 s … 10.354 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.350 s ±  0.038 s    [User: 38.437 s, System: 0.952 s]
  Range (min … max):   10.323 s … 10.376 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.00 ± 0.00 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.142 s ±  0.078 s    [User: 38.398 s, System: 0.952 s]
  Range (min … max):   10.087 s … 10.198 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.388 s ±  0.075 s    [User: 38.471 s, System: 0.961 s]
  Range (min … max):   10.335 s … 10.441 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.02 ± 0.01 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.477 s ±  0.041 s    [User: 38.424 s, System: 1.017 s]
  Range (min … max):   10.448 s … 10.506 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.317 s ±  0.170 s    [User: 38.695 s, System: 1.017 s]
  Range (min … max):   10.196 s … 10.437 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.02 ± 0.02 times faster than hyper_threading_main threads: 16


@Stavbe Stavbe force-pushed the stav/keep_none_memory_values branch from 229b378 to 5b08179 Compare March 24, 2025 15:16
@Stavbe Stavbe self-assigned this Mar 24, 2025
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.122 ± 0.024 2.100 2.175 1.00
head big_factorial 2.123 ± 0.017 2.103 2.163 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.050 ± 0.024 2.027 2.108 1.00 ± 0.02
head big_fibonacci 2.049 ± 0.022 2.019 2.083 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.574 ± 0.107 7.481 7.807 1.00 ± 0.02
head blake2s_integration_benchmark 7.539 ± 0.091 7.422 7.772 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.199 ± 0.031 2.168 2.274 1.01 ± 0.02
head compare_arrays_200000 2.187 ± 0.018 2.167 2.227 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.437 ± 0.010 1.423 1.455 1.00
head dict_integration_benchmark 1.441 ± 0.012 1.426 1.462 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.212 ± 0.008 1.204 1.228 1.00
head field_arithmetic_get_square_benchmark 1.213 ± 0.012 1.199 1.235 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.591 ± 0.042 7.530 7.661 1.00
head integration_builtins 7.610 ± 0.145 7.522 8.017 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.854 ± 0.038 7.797 7.909 1.00 ± 0.01
head keccak_integration_benchmark 7.844 ± 0.056 7.789 7.987 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.175 ± 0.025 2.148 2.210 1.01 ± 0.01
head linear_search 2.158 ± 0.017 2.139 2.189 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.520 ± 0.007 1.510 1.530 1.00
head math_cmp_and_pow_integration_benchmark 1.534 ± 0.012 1.515 1.553 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.474 ± 0.009 1.460 1.490 1.00 ± 0.01
head math_integration_benchmark 1.472 ± 0.012 1.458 1.495 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.226 ± 0.013 1.212 1.249 1.00 ± 0.01
head memory_integration_benchmark 1.226 ± 0.010 1.211 1.245 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.591 ± 0.021 1.566 1.636 1.01 ± 0.02
head operations_with_data_structures_benchmarks 1.582 ± 0.013 1.570 1.607 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 535.0 ± 6.8 529.4 552.7 1.00 ± 0.01
head pedersen 532.8 ± 3.4 529.2 538.9 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 649.3 ± 7.8 639.2 662.7 1.01 ± 0.02
head poseidon_integration_benchmark 642.5 ± 7.5 635.6 655.3 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.860 ± 0.029 1.837 1.940 1.01 ± 0.02
head secp_integration_benchmark 1.847 ± 0.006 1.840 1.860 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 634.0 ± 7.0 626.8 645.7 1.00
head set_integration_benchmark 681.1 ± 2.6 678.1 686.7 1.07 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.230 ± 0.066 4.179 4.377 1.01 ± 0.02
head uint256_integration_benchmark 4.182 ± 0.026 4.157 4.239 1.00

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.53%. Comparing base (3aed532) to head (5b08179).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2021   +/-   ##
=======================================
  Coverage   96.53%   96.53%           
=======================================
  Files         102      102           
  Lines       42720    42726    +6     
=======================================
+ Hits        41241    41247    +6     
  Misses       1479     1479           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@DavidLevitGurevich DavidLevitGurevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @igaray, @YairVaknin-starkware, and @yuvalsw)

Copy link
Collaborator

@yuvalsw yuvalsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @igaray and @YairVaknin-starkware)

Copy link
Collaborator

@YairVaknin-starkware YairVaknin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @igaray)

@Stavbe Stavbe added this pull request to the merge queue Mar 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 25, 2025
@Stavbe Stavbe added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit f8e3a82 Mar 25, 2025
93 checks passed
@Stavbe Stavbe deleted the stav/keep_none_memory_values branch March 25, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants