fix: simplify tracer instruction encoding fetch #2289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation of get_instruction_encoding computed the immediate address using a modulo by the Cairo prime via BigUint, and accepted the program prime as a string parameter. In the relocated trace we work with plain usize indices into a contiguous memory vector, so (pc + 1) % prime is both unnecessary and misleading: the field modulus does not apply to memory indices. It also added avoidable allocations and parsing work per instruction and risked panics. The function now uses straightforward bounds-checked indexing (pc and pc + 1) and no longer depends on prime or BigUint, while the call site in
TracerData::new was updated accordingly.