Skip to content

Add flag to allow different builtins order #2292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
FrancoGiachetta wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add flag to allow different builtins order #2292

FrancoGiachetta wants to merge 4 commits into from

Conversation

@FrancoGiachetta
Copy link
Contributor

@FrancoGiachetta FrancoGiachetta commented Jan 9, 2026 •
edited
Loading

Add flag to allow different builtins order

Description

The PR add a new flag for the CairoRunner: allow_disordered_builtins. This flag allows for builtins to be passed to the runner with different orderings.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@github-actions
Copy link

github-actions bot commented Jan 9, 2026 •
edited
Loading 

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     23.818 s ±  0.093 s    [User: 22.977 s, System: 0.839 s]
  Range (min … max):   23.752 s … 23.884 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     23.353 s ±  0.170 s    [User: 22.500 s, System: 0.851 s]
  Range (min … max):   23.232 s … 23.473 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.02 ± 0.01 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     12.832 s ±  0.013 s    [User: 22.963 s, System: 0.872 s]
  Range (min … max):   12.823 s … 12.840 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     12.543 s ±  0.013 s    [User: 22.680 s, System: 0.846 s]
  Range (min … max):   12.534 s … 12.552 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.02 ± 0.00 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):      9.755 s ±  0.217 s    [User: 35.357 s, System: 1.086 s]
  Range (min … max):    9.602 s …  9.909 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):      9.896 s ±  0.019 s    [User: 34.953 s, System: 1.032 s]
  Range (min … max):    9.883 s …  9.910 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.01 ± 0.02 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):      9.576 s ±  0.157 s    [User: 35.533 s, System: 1.073 s]
  Range (min … max):    9.466 s …  9.687 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):      9.751 s ±  0.127 s    [User: 34.845 s, System: 1.116 s]
  Range (min … max):    9.661 s …  9.841 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.02 ± 0.02 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):      9.506 s ±  0.039 s    [User: 35.641 s, System: 1.109 s]
  Range (min … max):    9.478 s …  9.534 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):      9.473 s ±  0.061 s    [User: 35.397 s, System: 1.096 s]
  Range (min … max):    9.429 s …  9.516 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.00 ± 0.01 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):      9.720 s ±  0.016 s    [User: 35.767 s, System: 1.204 s]
  Range (min … max):    9.708 s …  9.731 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):      9.600 s ±  0.201 s    [User: 35.921 s, System: 1.158 s]
  Range (min … max):    9.458 s …  9.742 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.01 ± 0.02 times faster than hyper_threading_main threads: 16

@FrancoGiachetta FrancoGiachetta force-pushed the allow_disordered_builtins branch from ee1b9b1 to b9300c0 Compare January 9, 2026 19:58
@github-actions
Copy link

github-actions bot commented Jan 9, 2026 •
edited
Loading

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 1.969 ± 0.009 1.957 1.984 1.01 ± 0.01
head big_factorial 1.949 ± 0.017 1.928 1.990 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 1.921 ± 0.012 1.907 1.940 1.02 ± 0.01
head big_fibonacci 1.882 ± 0.019 1.870 1.934 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 6.955 ± 0.124 6.813 7.133 1.04 ± 0.06
head blake2s_integration_benchmark 6.710 ± 0.341 6.483 7.586 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.041 ± 0.015 2.016 2.070 1.02 ± 0.01
head compare_arrays_200000 1.992 ± 0.015 1.969 2.027 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.351 ± 0.005 1.344 1.357 1.01 ± 0.01
head dict_integration_benchmark 1.337 ± 0.014 1.323 1.369 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.154 ± 0.013 1.137 1.186 1.04 ± 0.01
head field_arithmetic_get_square_benchmark 1.112 ± 0.007 1.101 1.128 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.009 ± 0.062 6.942 7.154 1.05 ± 0.01
head integration_builtins 6.686 ± 0.029 6.645 6.731 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.081 ± 0.047 7.042 7.190 1.05 ± 0.01
head keccak_integration_benchmark 6.728 ± 0.047 6.637 6.780 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.023 ± 0.007 2.013 2.035 1.02 ± 0.01
head linear_search 1.990 ± 0.008 1.978 2.004 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.441 ± 0.005 1.434 1.453 1.01 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.428 ± 0.014 1.420 1.467 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.393 ± 0.014 1.376 1.416 1.01 ± 0.01
head math_integration_benchmark 1.376 ± 0.007 1.367 1.391 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.153 ± 0.008 1.142 1.172 1.02 ± 0.01
head memory_integration_benchmark 1.131 ± 0.004 1.125 1.139 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.469 ± 0.009 1.456 1.491 1.01 ± 0.01
head operations_with_data_structures_benchmarks 1.454 ± 0.004 1.448 1.458 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 511.9 ± 1.0 510.3 513.7 1.01 ± 0.00
head pedersen 507.2 ± 2.3 503.9 511.1 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 597.6 ± 2.0 594.9 601.4 1.01 ± 0.01
head poseidon_integration_benchmark 593.6 ± 3.7 588.2 601.4 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.722 ± 0.008 1.714 1.741 1.01 ± 0.01
head secp_integration_benchmark 1.701 ± 0.008 1.689 1.718 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 662.8 ± 2.0 659.9 666.3 1.02 ± 0.01
head set_integration_benchmark 649.9 ± 2.9 645.2 654.6 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 3.964 ± 0.049 3.932 4.095 1.03 ± 0.01
head uint256_integration_benchmark 3.835 ± 0.011 3.822 3.862 1.00

@codecov
Copy link

codecov bot commented Jan 9, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.98%. Comparing base (dbc5dab) to head (6db7120).

Files with missing lines Patch % Lines
vm/src/cairo_run.rs 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2292      +/-   ##
==========================================
- Coverage   95.98%   95.98%   -0.01%     
==========================================
  Files         104      104              
  Lines       36872    36892      +20     
==========================================
+ Hits        35392    35411      +19     
- Misses       1480     1481       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FrancoGiachetta