Skip to content

Conversation

@fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Oct 20, 2025

Motivation
Enable hive p2p test BlobViolations
This test behaves by first sending a NewPooledTransactionHashes message, and then responding to our node's GetPooledTransaction with a NewPooledTransactions message that contains transactions with sizes & types that don't match the ones advertised in the first message. As we were not keeping track of the received NewPooledTransactionHashes messages, we were not able to validate the incoming transactions. This PR fixes this problem and re-enables the test

Description

  • Track incoming NewPooledTransactionHashes
  • Enable hive p2p BlobViolations test

Part of #4941

@github-actions github-actions bot added the L1 Ethereum client label Oct 20, 2025
@github-actions
Copy link

Lines of code report

Total lines added: 3
Total lines removed: 0
Total lines changed: 3

Detailed view
+--------------------------------------------------------+-------+------+
| File                                                   | Lines | Diff |
+--------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/rlpx/connection/server.rs | 988   | +3   |
+--------------------------------------------------------+-------+------+

@fmoletta fmoletta marked this pull request as ready for review October 20, 2025 20:11
@fmoletta fmoletta requested a review from a team as a code owner October 20, 2025 20:11
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

2 participants