fix(l1): track requested pooled transactions #4962
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Enable hive p2p test BlobViolations
This test behaves by first sending a
NewPooledTransactionHashesmessage, and then responding to our node'sGetPooledTransactionwith aNewPooledTransactionsmessage that contains transactions with sizes & types that don't match the ones advertised in the first message. As we were not keeping track of the receivedNewPooledTransactionHashesmessages, we were not able to validate the incoming transactions. This PR fixes this problem and re-enables the testDescription
NewPooledTransactionHashesBlobViolationstestPart of #4941