Skip to content

Conversation

@fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Oct 20, 2025

Motivation
Enable hive p2p tests TestBlobTxWithMismatchedSidecar & TestBlobTxWithoutSidecar
In order to pass these tests we have to:

  • Be able to decode pooled transactions without blobs (aka plain eip4844 transactions instead of a wrapped eip4844 with its blobsbundle)
  • Disconnect from peers that send transactions without blobs or blob bundles that don't match the versioned hashes

Description

  • Handle the case of plain Eip4844 transaction when RLP-decoding WrappedEip4844 transactions
  • Disconnect from peers that send empty/mismatched blobs

Closes #3745, part of #4941

@github-actions github-actions bot added the L1 Ethereum client label Oct 20, 2025
@github-actions
Copy link

github-actions bot commented Oct 20, 2025

Lines of code report

Total lines added: 47
Total lines removed: 0
Total lines changed: 47

Detailed view
+--------------------------------------------------------+-------+------+
| File                                                   | Lines | Diff |
+--------------------------------------------------------+-------+------+
| ethrex/crates/common/types/blobs_bundle.rs             | 387   | +19  |
+--------------------------------------------------------+-------+------+
| ethrex/crates/common/types/transaction.rs              | 2848  | +10  |
+--------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/rlpx/connection/server.rs | 1003  | +18  |
+--------------------------------------------------------+-------+------+

@fmoletta fmoletta force-pushed the check-pooled-tx-blobs branch from 7085f7d to 4556943 Compare October 21, 2025 18:25
@fmoletta fmoletta marked this pull request as ready for review October 21, 2025 19:51
@fmoletta fmoletta requested a review from a team as a code owner October 21, 2025 19:51
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

Disconnect peers whenever they send invalid blob transactions in PooledTransactions

2 participants