Feat/fast division #1001
Open
Feat/fast division #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xLucqs
force-pushed
the
feat/fast_division
branch
from
a0cd1b6 to
d21d834
Compare
0xLucqs
force-pushed
the
feat/fast_division
branch
from
d21d834 to
28a868b
Compare
| let d = n - m; // Degree of the quotient | ||
| let a_rev = self.reverse(n); | ||
| let b_rev = divisor.reverse(m); | ||
| let inv_b_rev = Self::invert_polynomial_mod::<F>(&b_rev, d + 1)?; |
There was a problem hiding this comment.
I don't get why this is faster than just evaluating the divisor polynomial at the FFT points, doing batch inverse and then multiplying everything out and interpolating. The method for inversion seems a bit convoluted
There was a problem hiding this comment.
I don't think your suggestion works when there is a remainder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TITLE
Description
Description of the pull request changes and motivation.
Type of change
Please delete options that are not relevant.
Checklist