feat(stark): add LogUp lookup argument module with bus abstraction

crates/math/src/field/fields/u64_goldilocks_field.rs

@@ -11,8 +11,11 @@
 use core::fmt::{self, Display};
 
 use crate::errors::CreationError;
+use crate::field::traits::HasDefaultTranscript;
 use crate::field::traits::{IsFFTField, IsField, IsPrimeField, IsSubFieldOf};
 use crate::field::{element::FieldElement, errors::FieldError};
+#[cfg(feature = "alloc")]
+use crate::traits::AsBytes;
 use crate::traits::ByteConversion;
 
 // =====================================================
@@ -299,6 +302,13 @@ impl ByteConversion for FieldElement<Goldilocks64Field> {
     }
 }
 
+#[cfg(feature = "alloc")]
+impl AsBytes for FieldElement<Goldilocks64Field> {
+    fn as_bytes(&self) -> alloc::vec::Vec<u8> {
+        self.to_bytes_be()
+    }
+}
+
 // =====================================================
 // x86-64 ASSEMBLY OPTIMIZATIONS
 // =====================================================
@@ -836,6 +846,55 @@ impl Fp2E {
     }
 }
 
+impl ByteConversion for FieldElement<Degree2GoldilocksExtensionField> {
+    #[cfg(feature = "alloc")]
+    fn to_bytes_be(&self) -> alloc::vec::Vec<u8> {
+        let mut bytes = alloc::vec::Vec::with_capacity(16);
+        bytes.extend_from_slice(&self.value()[0].to_bytes_be());
+        bytes.extend_from_slice(&self.value()[1].to_bytes_be());
+        bytes
+    }
+
+    #[cfg(feature = "alloc")]
+    fn to_bytes_le(&self) -> alloc::vec::Vec<u8> {
+        let mut bytes = alloc::vec::Vec::with_capacity(16);
+        bytes.extend_from_slice(&self.value()[0].to_bytes_le());
+        bytes.extend_from_slice(&self.value()[1].to_bytes_le());
+        bytes
+    }
+
+    fn from_bytes_be(bytes: &[u8]) -> Result<Self, crate::errors::ByteConversionError>
+    where
+        Self: Sized,
+    {
+        if bytes.len() < 16 {
+            return Err(crate::errors::ByteConversionError::FromBEBytesError);
+        }
+        let x0 = FpE::from_bytes_be(&bytes[..8])?;
+        let x1 = FpE::from_bytes_be(&bytes[8..16])?;
+        Ok(Self::new([x0, x1]))
+    }
+
+    fn from_bytes_le(bytes: &[u8]) -> Result<Self, crate::errors::ByteConversionError>
+    where
+        Self: Sized,
+    {
+        if bytes.len() < 16 {
+            return Err(crate::errors::ByteConversionError::FromLEBytesError);
+        }
+        let x0 = FpE::from_bytes_le(&bytes[..8])?;
+        let x1 = FpE::from_bytes_le(&bytes[8..16])?;
+        Ok(Self::new([x0, x1]))
+    }
+}
+
+#[cfg(feature = "alloc")]
+impl AsBytes for FieldElement<Degree2GoldilocksExtensionField> {
+    fn as_bytes(&self) -> alloc::vec::Vec<u8> {
+        self.to_bytes_be()
+    }
+}
+
 // =====================================================
 // CUBIC EXTENSION (Fp3)
 // =====================================================
@@ -1000,6 +1059,31 @@ impl IsSubFieldOf<Degree3GoldilocksExtensionField> for Goldilocks64Field {
 /// Field element type for the cubic extension
 pub type Fp3E = FieldElement<Degree3GoldilocksExtensionField>;
 
+// =====================================================
+// DEFAULT TRANSCRIPT SUPPORT
+// =====================================================
+
+impl HasDefaultTranscript for Goldilocks64Field {
+    fn get_random_field_element_from_rng(rng: &mut impl rand::Rng) -> FieldElement<Self> {
+        let mut sample = [0u8; 8];
+        loop {
+            rng.fill(&mut sample);
+            let int_sample = u64::from_be_bytes(sample);
+            if int_sample < GOLDILOCKS_PRIME {
+                return FieldElement::from(int_sample);
+            }
+        }
+    }
+}
+
+impl HasDefaultTranscript for Degree2GoldilocksExtensionField {
+    fn get_random_field_element_from_rng(rng: &mut impl rand::Rng) -> FieldElement<Self> {
+        let c0 = Goldilocks64Field::get_random_field_element_from_rng(rng);
+        let c1 = Goldilocks64Field::get_random_field_element_from_rng(rng);
+        FieldElement::<Self>::new([c0, c1])
+    }
+}
+
 // =====================================================
 // TESTS
 // =====================================================

crates/provers/stark/src/examples/fibonacci_rap.rs

@@ -208,7 +208,7 @@ where
         &self,
         trace: &mut TraceTable<Self::Field, Self::FieldExtension>,
         challenges: &[FieldElement<F>],
-    ) {
+    ) -> Result<(), crate::prover::ProvingError> {
         let main_segment_cols = trace.columns_main();
         let not_perm = &main_segment_cols[0];
         let perm = &main_segment_cols[1];
@@ -233,6 +233,7 @@ where
         for (i, aux_elem) in aux_col.iter().enumerate().take(trace.num_rows()) {
             trace.set_aux(i, 0, aux_elem.clone())
         }
+        Ok(())
     }
 
     fn build_rap_challenges(

crates/provers/stark/src/examples/read_only_memory.rs

@@ -284,7 +284,7 @@ where
         &self,
         trace: &mut TraceTable<Self::Field, Self::FieldExtension>,
         challenges: &[FieldElement<F>],
-    ) {
+    ) -> Result<(), crate::prover::ProvingError> {
         let main_segment_cols = trace.columns_main();
         let a = &main_segment_cols[0];
         let v = &main_segment_cols[1];
@@ -311,6 +311,7 @@ where
         for (i, aux_elem) in aux_col.iter().enumerate().take(trace.num_rows()) {
             trace.set_aux(i, 0, aux_elem.clone())
         }
+        Ok(())
     }
 
     fn build_rap_challenges(

crates/provers/stark/src/examples/read_only_memory_logup.rs

@@ -415,7 +415,7 @@ where
         &self,
         trace: &mut TraceTable<Self::Field, Self::FieldExtension>,
         challenges: &[FieldElement<E>],
-    ) {
+    ) -> Result<(), crate::prover::ProvingError> {
         // Main table
         let main_segment_cols = trace.columns_main();
         let a = &main_segment_cols[0];
@@ -449,6 +449,7 @@ where
         for (i, aux_elem) in aux_col.iter().enumerate().take(trace.num_rows()) {
             trace.set_aux(i, 0, aux_elem.clone())
         }
+        Ok(())
     }
 
     fn build_rap_challenges(

crates/provers/stark/src/lib.rs

@@ -10,6 +10,7 @@ pub mod examples;
 pub mod frame;
 pub mod fri;
 pub mod grinding;
+pub mod lookup;
 pub mod multi_table_prover;
 pub mod multi_table_verifier;
 pub mod proof;