fix(cache): invalidate only touched dataset entries#186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR narrows Lance dataset cache invalidation to the touched dataset key instead of clearing the whole per-connection cache. Path-backed tables now key on resolved open path plus storage options, and namespace-backed tables key on endpoint plus table ID plus auth/header fingerprint, so writes to dataset A no longer evict cached handles for unrelated datasets B/C.
It also threads cache keys through transactional write paths and adds a sqllogictest covering precise invalidation after a write. Validation in this environment was limited to code review and
git diff --check; local format/build/test commands were blocked becauseuv,ninja, and the DuckDB format script were denied by host system policy.