Check for null before stringifying objects

[dextermb]

Somewhat related to #30, as null is an object in JavaScript it gets caught by the object if-statement and then gets stringified which converts it to a string.

I think it would be best to check for null, and return a string before rendering the cell. Thoughts?

[DivineOmega]

I don't see this as a problem. In fact, in a way it is an advantage.

It allows you to just use the dataItemManipulator prop to modify the null to a more appropriate value, such as a dash, a blank space, or something similar to 'No end date'.

[dextermb]

I don't see this as a problem. In fact, in a way it is an advantage.

It allows you to just use the dataItemManipulator prop to modify the null to a more appropriate value, such as a dash, a blank space, or something similar to 'No end date'.

It's not null, it's 'null'. I think at least the default manipulator should hide it.

[DivineOmega]

Okay. Are you proposing converting null into `` (empty string) before it is displayed?

[dextermb]

Okay. Are you proposing converting null into `` (empty string) before it is displayed?

Yessir

Edit:
You would edit the renderCell function in DataRow:

value = this.props.dataItemManipulator(field.name, value);

if (value === null) {
    value = '';
}

if (typeof value === 'object' || typeof value === 'array') {
    value = JSON.stringify(value);
}

Source. Might even be worth throwing in a safety catch for undefined (event though undefined is not an object), so the new if-statement would become value === null || value === undefined.

[DivineOmega]

That makes sense, assuming you can not think of any scenerios in which we would want to differentiate between null and empty string.

[dextermb]

That makes sense, assuming you can not think of any scenerios in which we would want to differentiate between null and empty string.

You could either check for null in the renderCell or maybe have the default dataItemManipulator check for null and return an empty string. This way the user would have the power.

[DivineOmega]

I like the latter suggestion. 👍

[...] have the default dataItemManipulator check for null and return an empty string. This way the user would have the power.