Skip to content

Check if null before returning value #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2019
Merged

Check if null before returning value #52

merged 2 commits into from
Feb 5, 2019

Conversation

dextermb
Copy link
Contributor

@dextermb dextermb commented Dec 14, 2018 •
edited
Loading

Closes #50

@dextermb dextermb requested a review from DivineOmega December 14, 2018 10:54
DivineOmega
DivineOmega suggested changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@DivineOmega DivineOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but technically, this is a breaking change as people could be using the current null string behaviour. Bump the version to 3.0.0 and I'll merge it in. 👍

@dextermb
Copy link
Contributor Author

@DivineOmega Is it not worth getting some other pull requests done before publishing? Like documenting DynamicAjaxDataTable?

@DivineOmega
Copy link
Contributor

@dextermb Certainly a good idea. 👍

I'd recommend we bump the version number in this PR, get it merged, and then when we've done sufficient additional breaking PRs, publish.

@dextermb
Copy link
Contributor Author

@DivineOmega Done 👍

@DivineOmega
Copy link
Contributor

@dextermb Shall I publish immediately or do you have other issues you intend to work on?

@dextermb
Copy link
Contributor Author

dextermb commented Jan 2, 2019

@dextermb Shall I publish immediately or do you have other issues you intend to work on?

Can push for now, as we are smashing another project at the moment. Will have to come back to the other issues another time.

Although this change is not required for what we are doing

@DivineOmega DivineOmega merged commit 4c7000e into langleyfoxall:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DivineOmega DivineOmega DivineOmega approved these changes

@NilesB NilesB NilesB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dextermb @DivineOmega @NilesB