Skip to content

Conversation

@Westie
Copy link
Contributor

@Westie Westie commented Jan 17, 2025

This library doesn't at present support v5.x of https://github.com/laravel-json-api/laravel

This PR will resolve this.

david.weston@Westies-WorkBook-Pro hashids % ./vendor/bin/phpunit 
PHPUnit 10.5.41 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.9
Configuration: /Users/david.weston/www-data/hashids/phpunit.xml

...............                                                   15 / 15 (100%)

Time: 00:00.079, Memory: 22.00 MB

OK (15 tests, 25 assertions)

Copy link
Contributor

@lindyhopchris lindyhopchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I clearly missed this when tagging all the packages. It just needs one change to support both v4 and v5.

@Westie
Copy link
Contributor Author

Westie commented Jan 17, 2025

@lindyhopchris wasn't too sure on the version conventions in this library, that's sorted now.

@lindyhopchris lindyhopchris self-requested a review January 17, 2025 09:25
@lindyhopchris lindyhopchris merged commit 1d0fc96 into laravel-json-api:develop Jan 18, 2025
2 checks passed
@lindyhopchris
Copy link
Contributor

Tagged as v3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants