This repository was archived by the owner on Jun 29, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 8
Resolves #27 - Update question #41
Merged
josepostiga
merged 20 commits into
laravel-portugal:master
from
tiagof:feature/issue-27-Update-question
Oct 25, 2020
Merged
Resolves #27 - Update question #41
josepostiga
merged 20 commits into
laravel-portugal:master
from
tiagof:feature/issue-27-Update-question
Oct 25, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves laravel-portugal#25 Removes unnecessary code in AccountsStoreController.
Closes #27 |
I'll wait for #40 to be implemented before reviewing this one. |
… columns on links and tags tables" (laravel-portugal#38) * feat(Tags): add support to timestamps w/timezones - drop regular timestamps columns - create new ones with timestampsTz * feat(Links): add support to timestamps w/timezones added doctrine/dbal dependency * fix: add method return type * fix(Links): add missing timestamp (approved_at) * chore: converted timestampTz to softDeletesTz * feat(links): added approved_at datetime cast * fix: replaced dropColumn with change method * chore(Changelog): add latest updates timestamps columns (on links and tags) changed to datetime w/timezone
…ion (laravel-portugal#40) * init * Adds Question create feature resolves laravel-portugal#25 Removes unnecessary code in AccountsStoreController. * Added '/discussions' prefix As per laravel-portugal#25 (comment) * Minor fixes as per review laravel-portugal#40 (review) * Cleanup
ab99eb4
to
4c07b31
Compare
…/tiagof/api into feature/issue-27-Update-question
@josepostiga, after a fierce battle with git, it's ready for review. |
josepostiga
suggested changes
Oct 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much to say besides thanks for this! We just need to work out a few details, but is pretty much ready to merge.
Keep up the good work 👍
josepostiga
suggested changes
Oct 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! Let's try to finish some details off and prepare this to get merged.
P.s.: don't forget to update the changelog file, please.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.