Skip to content
This repository was archived by the owner on Jun 29, 2021. It is now read-only.

Resolves #27 - Update question #41

Merged

Conversation

tiagof
Copy link
Collaborator

@tiagof tiagof commented Oct 14, 2020

No description provided.

resolves laravel-portugal#25
Removes unnecessary code in AccountsStoreController.
@tiagof tiagof changed the title [WIP] Feature/issue 27 update question Feature/issue 27 update question Oct 14, 2020
@tiagof tiagof marked this pull request as ready for review October 14, 2020 11:16
@tiagof
Copy link
Collaborator Author

tiagof commented Oct 14, 2020

Closes #27

@tiagof tiagof changed the title Feature/issue 27 update question Resolves #27 - Update question Oct 14, 2020
@tiagof tiagof linked an issue Oct 14, 2020 that may be closed by this pull request
@josepostiga
Copy link
Member

I'll wait for #40 to be implemented before reviewing this one.

@josepostiga josepostiga self-requested a review October 16, 2020 07:59
tiagof and others added 7 commits October 16, 2020 10:20
… columns on links and tags tables" (laravel-portugal#38)

* feat(Tags): add support to timestamps w/timezones

- drop regular timestamps columns
- create new ones with timestampsTz

* feat(Links): add support to timestamps w/timezones

added doctrine/dbal dependency

* fix: add method return type

* fix(Links): add missing timestamp (approved_at)

* chore: converted timestampTz to softDeletesTz

* feat(links): added approved_at datetime cast

* fix: replaced dropColumn with change method

* chore(Changelog): add latest updates

timestamps columns (on links and tags) changed to datetime w/timezone
…ion (laravel-portugal#40)

* init

* Adds Question create feature

resolves laravel-portugal#25
Removes unnecessary code in AccountsStoreController.

* Added '/discussions' prefix

As per laravel-portugal#25 (comment)

* Minor fixes as per review

laravel-portugal#40 (review)

* Cleanup
@tiagof tiagof force-pushed the feature/issue-27-Update-question branch from ab99eb4 to 4c07b31 Compare October 17, 2020 10:33
@tiagof
Copy link
Collaborator Author

tiagof commented Oct 17, 2020

@josepostiga, after a fierce battle with git, it's ready for review.

Copy link
Member

@josepostiga josepostiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to say besides thanks for this! We just need to work out a few details, but is pretty much ready to merge.

Keep up the good work 👍

@tiagof tiagof requested a review from josepostiga October 20, 2020 08:57
Copy link
Member

@josepostiga josepostiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Let's try to finish some details off and prepare this to get merged.

P.s.: don't forget to update the changelog file, please.

@tiagof tiagof requested a review from josepostiga October 24, 2020 17:50
@josepostiga josepostiga merged commit a62c58a into laravel-portugal:master Oct 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An authenticated user can update a question
3 participants