Skip to content
This repository was archived by the owner on Jun 29, 2021. It is now read-only.

Resolves #26 - A guest or an authenticated user can list questions #51

Merged
merged 31 commits into from
Nov 1, 2020
Merged

Resolves #26 - A guest or an authenticated user can list questions #51

merged 31 commits into from
Nov 1, 2020

Conversation

dleicam
Copy link
Contributor

@dleicam dleicam commented Oct 27, 2020 •
edited
Loading

Resolved (#26)

@dleicam dleicam changed the title Resolve A guest or an authenticated user can list questions (#26) Resolved - A guest or an authenticated user can list questions (#26) Oct 27, 2020
@tiagof tiagof linked an issue Oct 27, 2020 that may be closed by this pull request
A guest or an authenticated user can list questions #26
Closed
@dleicam
Resolved - A guest or an authenticated user can list questions (larav…
6824f33 
…el-portugal#26) - Refactoring
@dleicam
Resolved - A guest or an authenticated user can list questions (larav…
3db0e2c 
…el-portugal#26) - Refactoring
@dleicam
Resolved - A guest or an authenticated user can list questions (larav…
c66551d 
…el-portugal#26) - minor cleanup and code style fixes
@dleicam
Resolved - A guest or an authenticated user can list questions (larav…
c0c809e 
…el-portugal#26) - Tests refactoring
@dleicam
Resolved - A guest or an authenticated user can list questions (larav…
5d2f639 
…el-portugal#26) - Replaced controller name to QuestionsIndexController
@dleicam
Resolved - A guest or an authenticated user can list questions (larav…
b70747c 
…el-portugal#26) - minor replaces
@dleicam
Resolved - A guest or an authenticated user can list questions (larav…
e33b098 
…el-portugal#26) - add resolved_at to QuestionResource, code style
@josepostiga josepostiga changed the title Resolved - A guest or an authenticated user can list questions (#26) Resolves #26 - A guest or an authenticated user can list questions Oct 28, 2020
josepostiga
josepostiga suggested changes Oct 28, 2020
View reviewed changes
Copy link
Member

@josepostiga josepostiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, so far. Let's iterate over this and discuss the notes I've left here 👍

@dleicam dleicam requested a review from josepostiga October 28, 2020 13:49
@dleicam
Merge branch 'master' of https://github.com/laravel-portugal/api into…
cfb1e5d 
… Issues-26

� Conflicts:
�	domains/Discussions/routes.php
josepostiga
josepostiga suggested changes Oct 29, 2020
View reviewed changes
Copy link
Member

@josepostiga josepostiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting really good! 👍

There are still a few details I think are worth discussing and reviewing, but that should be it!

@dleicam dleicam requested review from josepostiga and tiagof October 29, 2020 14:09
José Postiga and others added 9 commits November 1, 2020 09:46
tests(Discussions): minor improvements
981534c
chore(Changelog): updated with latest changes
b46b222
@dleicam
Resolve A guest or an authenticated user can list questions (laravel-…
d5fbfbf 
…portugal#26)
@dleicam
Resolve A guest or an authenticated user can list questions (laravel-…
9b0628e 
…portugal#26)
@dleicam
Resolved - A guest or an authenticated user can list questions (larav…
56e6bf7 
…el-portugal#26)
@dleicam
Resolved - A guest or an authenticated user can list questions (larav…
1cc2a16 
…el-portugal#26) - Refactoring
@dleicam
Resolved - A guest or an authenticated user can list questions (larav…
d9be4ce 
…el-portugal#26) - Refactoring
@dleicam
Resolved - A guest or an authenticated user can list questions (larav…
5d94119 
…el-portugal#26) - minor cleanup and code style fixes
@dleicam
Resolved - A guest or an authenticated user can list questions (larav…
11d7aea 
…el-portugal#26) - Tests refactoring
dleicam and others added 9 commits November 1, 2020 09:51
@dleicam
Resolved - A guest or an authenticated user can list questions (larav…
1b4bd09 
…el-portugal#26) - Replaced controller name to QuestionsIndexController
@dleicam
Resolved - A guest or an authenticated user can list questions (larav…
8a5d793 
…el-portugal#26) - minor replaces
@dleicam
Resolved - A guest or an authenticated user can list questions (larav…
52fb900 
…el-portugal#26) - add resolved_at to QuestionResource, code style
@dleicam
Resolved - A guest or an authenticated user can list questions (larav…
57a4abc 
…el-portugal#26) - Request change
@dleicam
Resolved - A guest or an authenticated user can list questions (larav…
36c0f06 
…el-portugal#26) - Request change
tests(Discussions): minor improvements
a8fe49f
chore(Changelog): updated with latest changes
7fbec12
chore(Discussions): rebased from master
6256299
Merge remote-tracking branch 'dleicam/Issues-26' into Issues-26
dab807d 
# Conflicts:
#	domains/Discussions/routes.php
@josepostiga josepostiga merged commit fee0d4b into laravel-portugal:master Nov 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josepostiga josepostiga josepostiga approved these changes

@tiagof tiagof Awaiting requested review from tiagof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A guest or an authenticated user can list questions
3 participants
@dleicam @tiagof @josepostiga