Skip to content

[12.x] prefix casts with "As" #10343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Conversation

browner12
Copy link
Contributor

while this is definitely a subjective change, I think it provides some significant benefits:

  • consistent naming pattern with Laravel internal casts
  • prefix helps indicate a cast object, and avoid confusion with names of value objects
  • avoids having to alias imports. value objects get the noun, and casts get the prefix.

generally speaking, I think these changes improve readability and consistency.

while this is definitely a subjective change, I think it provides some significant benefits:

- consistent naming pattern with Laravel internal casts
- prefix helps indicate a cast object, and avoid confusion with names of value objects
- avoids having to alias imports. value objects get the noun, and casts get the prefix.

generally speaking, I think these changes improve readability and consistency.
@taylorotwell taylorotwell merged commit 0bcc79f into laravel:12.x Apr 23, 2025
@browner12 browner12 deleted the AB-cast-as branch April 23, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants