Skip to content

[12.x] Passport 13.x #9819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 34 commits into
base: 12.x
Choose a base branch
from

Conversation

hafezdivandari
Copy link
Contributor

@hafezdivandari hafezdivandari commented Aug 14, 2024

Passport 13.x

@hafezdivandari hafezdivandari changed the base branch from 11.x to master February 17, 2025 18:54
@hafezdivandari hafezdivandari changed the title [11.x] Passport 13.x [12.x] Passport 13.x Feb 17, 2025
@hafezdivandari hafezdivandari changed the base branch from master to 12.x February 22, 2025 19:47
*/
public function boot(): void
{
Passport::authorizationView('auth.oauth.authorize');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to instruct users what this view should actually contain and what it should do on approval / denial.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instruction has been added.

public function boot(): void
{
Passport::deviceUserCodeView('auth.oauth.device.user-code');
Passport::deviceAuthorizationView('auth.oauth.device.authorize');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, we should tell people what to put in these views.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instruction has been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants