[12.x] Fix adding tags on new cache flush events #55169
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Alternative solution to #55157. Comes from discussion on #55142.
In #55121, Taylor said that the new
CacheFlushedorCacheFlushingevents should not extendCacheEvent. This makes sense since theCacheEventis for events with a specific$key.However, that means that we now have cache events that do not share a common ancestor and these events cannot have their tags set in
TaggedCache(orRedisTaggedCache).What
This PR attempts to fix this issue by adding a
TaggedCacheEventinterface with asetTagsmethod and makingCacheEvent,CacheFlushing, andCacheFlushedimplement it.An alternative solution to this would be to allow
CacheFlushingandCacheFlushedextendCacheEventwith an empty key (see #55157).