fix(database): prevent lock table overflow in model:prune by chunking transactions #57413
+275
−4,077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When running the
php artisan model:prune
command on very large datasets, MySQL can throw this error:This happens because deleting many records in a single transaction can overwhelm InnoDB’s lock table.
This PR updates the
pruneAll()
method to wrap each chunk (default 1000 rows) within individual transactions. That way, locks are released between chunks, reducing memory and lock pressure.Changes
src/Illuminate/Database/Eloquent/Prunable.php
, wrap each chunk’s iteration in:Why This Change Matters
Testing & Validation
Additional Notes