Skip to content

Support validating all fields when no or empty only property is passed #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Support validating all fields when no or empty only property is passed #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ const resolveConfig = (config: Config): Config => {
...config.precognitive !== false ? {
Precognition: true,
} : {},
...only ? {
...only && Array.from(only).length ? {
'Precognition-Validate-Only': Array.from(only).join(),
} : {},
},
Expand Down
16 changes: 16 additions & 0 deletions packages/core/tests/validator.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,22 @@ it('supports async validate with only key for untouched values', async () => {
await assertPendingValidateDebounceAndClear()
})

it('supports async validate without only key', async () => {
let config
axios.request.mockImplementation((c) => {
config = c

return Promise.resolve({ headers: { precognition: 'true', 'precognition-success': 'true' }, status: 204, data: '' })
})
const validator = createValidator((client) => client.post('/foo', {}))

validator.validate()

expect(config.headers).not.toHaveProperty('Precognition-Validate-Only')

await assertPendingValidateDebounceAndClear()
})

it('supports async validate with depricated validate key for untouched values', async () => {
let config
axios.request.mockImplementation((c) => {
Expand Down