Adding logic for hdf5 library #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 3, 2018 14:12
Conflicts: cmake/packages.cmake
cmsquared
approved these changes
Dec 19, 2018
| @@ -0,0 +1,41 @@ | |||
| #------------------------------------------------------------------------------# | |||
| # Copyright (c) 2014 Los Alamos National Security, LLC | |||
There was a problem hiding this comment.
I'm being pedantic, but this should probably be changed.
There was a problem hiding this comment.
@cmsquared: agree. I'll fix it in few minutes
junghans
reviewed
Mar 15, 2019
| list(APPEND CINCH_RUNTIME_LIBRARIES ${HDF5_LIBRARIES} ${HDF5_CXX_LIBRARIES}) | ||
|
|
||
| if(EXISTS "${HDF5_INCLUDE_DIRS}/../lib/libhdf5_cpp_debug.so") | ||
| list(APPEND CINCH_RUNTIME_LIBRARIES ${HDF5_INCLUDE_DIRS}/../lib/libhdf5_cpp_debug.so ) |
There was a problem hiding this comment.
That seems a bit hackish to me!
|
@junghans we don't need HDF5 cpp anymore, so I will just remove it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.