Fix spam log messages about sticky faults on Spark #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code looks like it's intended to only cause a log message if the state of sticky faults changes in some way. getStickyFaults() retuns a new java object each time, so using == for comparison on the object will always return true. This change looks at the rawBits of the fault object instead. old behavior = log message once a second even if there are no sticky faults new behavior = log message only when the bits actually change It might arguably be better to log once a second but only when there are faults so that the presence of faults is easier to see in a busy log file.
|
That's a great catch! In that case, the if statement should probably check the following: And then we also don't need to store the previous fault state in the hashmap. |
|
Logging Spark warnings in the SparkMonitor in a similar fashion might prove useful as well. |
|
I updated the PR to compare if rawBits=0 and removed the tracking of previous state as you suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code looks like it's intended to only cause a log message if the state of sticky faults changes in some way.
getStickyFaults() retuns a new java object each time, so using == for comparison on the object will always return true.
This change looks at the rawBits of the fault object instead.
old behavior = log message once a second even if there are no sticky faults
new behavior = log message only when the bits actually change
It might arguably be better to log once a second but only when there are faults so that the presence of faults is easier to see in a busy log file (but this doesn't do that). If the code is changed in that way, this class could have a lot of code removed.