Reduce the number of unimplemnetd functions #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simo5
changed the title
simo5
force-pushed
the
more_fns
branch
2 times, most recently
from
421d318 to
193042f
Compare
Jakuje
reviewed
Mar 5, 2025
Jakuje
approved these changes
Mar 5, 2025
Contributor
Jakuje
left a comment
Jakuje
left a comment
There was a problem hiding this comment.
Just one typo in commit message: s/signle/single/. Otherwise lgtm
These functions only return CKR_FUNCTION_NOT_PARALLEL by spec. Get them off the plate of the "unimplemented" functions. Signed-off-by: Simo Sorce <[email protected]>
PKCS#11 allows multiple operations of different types to be executed in parallel on a token. Drop the single operation enum method, and instead allow storage for each type of operation on the session. This also improves compile times checks, and drops runtime checks to check that the correct operation type is being accessed. Fixes latchset#168 Signed-off-by: Simo Sorce <[email protected]>
Signed-off-by: Simo Sorce <[email protected]>
Signed-off-by: Simo Sorce <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactors how operations are handled to fix #168