Combined functions support #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements: - C_DigestEncryptUpdate - C_DecryptDigestUpdate - A roundtrip test Signed-off-by: Simo Sorce <[email protected]>
Jakuje
reviewed
Mar 7, 2025
Contributor
Jakuje
left a comment
Jakuje
left a comment
There was a problem hiding this comment.
just typos for now. I will have to wrap my head around the operations next week
Implements: - C_SignEncryptUpdate - C_DecryptVerifyUpdate - A roundtrip test Signed-off-by: Simo Sorce <[email protected]>
Member
Author
Note that I may add some de-duplication via a helper function for encryption/decryption, but haven't done it so far because just copy/paste looked cleaner. |
Jakuje
reviewed
Mar 10, 2025
Jakuje
approved these changes
Mar 10, 2025
Contributor
Jakuje
left a comment
Jakuje
left a comment
There was a problem hiding this comment.
regardless of the formatting changes, looks good!
This ensures the update code is identical between the regular and the combined operations. Signed-off-by: Simo Sorce <[email protected]>
Member
Author
|
Fixed style issues and merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for this functions was all already available, just a matter of wiring up the calls.
Implements digest/encrypt, decrypt/digest, sign/encrypt, decrypt/verify.