Update packaging template with final release #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add -s option to do git tagging and gpg signing only on request, so it is easier to test the release script w/o messing with signatures. Ensure tarballs are actually compressed, change to tar.gz as that's the format git archive understand by default. Signed-off-by: Simo Sorce <[email protected]>
Contributor
Author
|
will have to figure out the source for the rpm build as for now it is using the crate. Likely based on the script from #177. |
This way reviewers and committers have a checkilist to not forget about required steps Signed-off-by: Simo Sorce <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
Jakuje
force-pushed
the
packaging-release
branch
from
bd808da to
6b4d73e
Compare
Jakuje
force-pushed
the
packaging-release
branch
4 times, most recently
from
bb72cd6 to
b3072c9
Compare
Adjust also CI to test the vendored dependencies. Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
Jakuje
force-pushed
the
packaging-release
branch
from
b3072c9 to
b931ea0
Compare
Closed
simo5
approved these changes
Mar 13, 2025
| %if %{with check} | ||
| %check | ||
| %if 0%{?rhel} | ||
| %cargo_test -f dynamic,nssdb,standard -- -- --exact --skip tests::signatures::test_rsa_signatures |
Member
There was a problem hiding this comment.
I deally we should fix the sha1 tests instead of skipping them all, but that would take more time, tagging this comment to issue #181 I filed to fix this in general so that we do not forget to change this back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly adding gpgcheck and links to the final release.