Skip to content

Conversation

@simo5
Copy link
Member

@simo5 simo5 commented Mar 12, 2025

Rebases the openssl submodule from a version based on Openssl 3.2 to a pre-release of the code that will go in Openssl 3.5.0 with additional patches from Red Hat for fips compliance nd sha1 hardening.

The fips indicator stuff had to be overhauled.

Note:
Two test do not correctly report unapproved fips indicators and will need more investigation.
It may be due to incomplete patching on the openssl side wrt indicators we used to check previously. Keeping PR as draft until openssl branches upstream and thse two test are investigated.

@simo5 simo5 marked this pull request as draft March 12, 2025 20:00
@simo5 simo5 requested a review from Jakuje March 12, 2025 20:00
@simo5 simo5 force-pushed the ossl35 branch 3 times, most recently from 39598c2 to 0c8f901 Compare March 12, 2025 22:02
@simo5 simo5 changed the title Draft: Rebase openssl submodule to 3.5 (prerelease) Rebase openssl submodule to 3.5 (prerelease) Mar 12, 2025
@simo5
Copy link
Member Author

simo5 commented Mar 13, 2025

I added a commit to get the fips version from the crate, also fixed the various other issues.
PTAL.

@simo5
Copy link
Member Author

simo5 commented Mar 14, 2025

Updated the openssl submodule to be a descendant of the new upstream openssl-3.5 branch instead of the openssl/master branch

@simo5 simo5 force-pushed the ossl35 branch 3 times, most recently from 40d8281 to bb85676 Compare March 27, 2025 13:39
@simo5 simo5 force-pushed the ossl35 branch 5 times, most recently from b32836d to cee2b0a Compare March 31, 2025 21:00
@simo5
Copy link
Member Author

simo5 commented Apr 1, 2025

I added a helper function for fips_approval and rebased to latest ossl35 branch_patches, PTAL

@simo5 simo5 marked this pull request as ready for review April 1, 2025 16:01
simo5 added 2 commits April 1, 2025 13:32
Instead of using the Red Hat custom indicators, try to use the
upstream openssl indicator facility introduced in 3.5.

Signed-off-by: Simo Sorce <[email protected]>
simo5 added 3 commits April 1, 2025 13:32
This build/test standard algorithm selection but against a static build
of openssl instead of the default dynamic build against the openssl
version of the system

Signed-off-by: Simo Sorce <[email protected]>
@simo5 simo5 merged commit 2040694 into latchset:main Apr 2, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants